Make downloading a patch/diff consistent across commits and merge requests
Problem to solve
The option to download an email patch or diff is not consistent across the UI.
When viewing a commit, the download options open the patch/diff in a new window.
But when viewing a merge request, the same options download the patch/diffs as files to be saved.
Anyone downloading patches/diffs, which could be most users but is typically:
- Sasha, Software Developer, https://design.gitlab.com/research/personas#persona-sasha
Make the UI consistent. For lack of an unambiguously better option, maybe the "open in new window" option would be simpler.
What does success look like, and how can we measure that?
Without this change the potential impact is that we irritate some users because they have to use the UI differently depending on which part of the UI they use, even though they're trying to do the same thing in each case. Arguably it would be a minor irritation, otherwise someone else would probably have opened an issue by now.
On the other hand, if we change the UI someone might complain because of the change and they weren't aware of or bothered by the inconsistency.
So success would look like no-one complaining, and maybe greater use of the feature. I don't know how that could be measured other than a usage ping or a user survey, both of which seem excessive for such a minor thing.