Show merge request discussions accross diffs
I am not sure whether this is a bug or a new feature... Anyway, it is observed on gitlab.com, 11.8.0-rc8-ee.
Problem to solve
The problem to solve: how to answer the question "I started a discussion to review a merge request: how was it taken into account?"
On a given merge request, discussions started on a given version are not shown in diff view of later versions. Showing the discussions (unresolved or not) will ease code review tracking by giving a quick view on what was done to take into account the review comments, and thus, what remains to do.
All actors in code review:
Further details: the current behaviour
How to reproduce this :
On a given repository, create a merge request (e.g.: from branch
master- this is just an example). This is
Start a discussion on a commit in this first version, let's say "asking the author to fix something".
The diff between
version 1(latest version) shows the discussion.
The author updates the merge request with what was requested (commit --amend and push -f), creating then
The diff between
version 1shows this update: "<The author> changed this line in version 2 of the diff".
However, the diff between
version 2(latest version now) does not show this discussion
An example project to illustrate this: alleen1/merge_requests!1
The discussion could be attached to the commit on
version 1 and shown when this version is the base of the diff.
Something which might look like this:
Thus: one can easily know how his comment was taken into account by looking at the diff.
What does success look like, and how can we measure that?
We could measure that by counting the necessary actions one should perform to answer our initial question.