Process for reviewing and accepting new or changed gitlab-ci.yml templates
Currently changes to .gitlab-ci.yml
template files for different languages or project frameworks go through the same review process as any other changes to the code base.
However they're different in a few ways:
- They're not production code that we're running
- They're not always in a language or framework that we have any experience in let alone expertise
Point 1 can lead us to lean in the direction of not taking them too seriously - however we are shipping them and we don't want to subject our customers to code that is incorrect or even malicious.
Point 2 can lead us to asking a reviewer or maintainer to take on a lot of work outside of their regular scope if they're not familiar with language used in the template.
We need to come up with a process or guidelines that doesn't add unnecessary load or work on our existing maintainer pools.
The motivation for this issue was a Community contribution coming in that gives us a template for the R
programming language: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25159/