Deployment job for a serverless function succeeds when a build fails
Description
When we are using tm
tool to deploy functions to Knative cluster, it might happen that a Knative build is going to fail because of various reasons.
# [...]
$ tm -n "$KUBE_NAMESPACE" deploy --wait
Creating functions-echo function
Deployment started. Run "tm -n kdemo-24 describe service functions-echo" to see the details
Waiting for functions-echo ready state
functions-echo: Revision "functions-echo-00001" failed with message: "build step \"build-step-build-and-push\" exited with code 1 (...); for logs run: kubectl -n kdemo-24 logs functions-echo-00001-jcrtd -c build-step-build-and-push".
Job succeeded
We do have an issue about using GitLab CI to have a better control over build process
This issue is about making sure that deployment job fails when it should,
Edited by Grzegorz Bizon