No errors displayed or logged when unable to connect to an external integration
Summary
Our internally-hosted GitLab instance is configured to integrate with a JIRA cloud instance. A network configuration change resulted in our GitLab instance being firewalled from the internet, which meant GitLab could no longer communicate with JIRA. However there was no indication in either the GitLab UI or error logs that this was the case: we were only able to diagnose the issue by running curl
to attempt to connect to the JIRA cloud instance, which failed.
Steps to reproduce
- Create a locally-hosted GitLab instance
- Once GitLab is configured correctly, add an integration to a JIRA cloud instance and save it to verify that it works
- Remove the JIRA integration
- Block the GitLab instance from accessing the internet
- Add the same, known working, JIRA integration from the previous steps
- Attempt to save the integration and note that the save fails with a generic "something went wrong on our end" error message
- Check the logs and note that nothing is recorded regarding the integration failure
What is the current bug behavior?
- The UI displays a generic error message instead of notifying that it could not connect to the JIRA cloud instance.
- The logs do not record anything about the connection failure.
What is the expected correct behavior?
- The UI informs the user that the integration could not be setup as GitLab is unable to connect to the JIRA cloud instance.
- The logs record all failures to connect to third-party integrations.
Relevant logs and/or screenshots
N/A
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 14.04 Current User: <REDACTED> Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.6 Bundler Version:1.16.6 Rake Version: 12.3.1 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.3 Go Version: unknownGitLab information Version: 11.6.0 Revision: 075f960 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://<REDACTED> HTTP Clone URL: https://<REDACTED>/some-group/some-project.git SSH Clone URL: git@<REDACTED>:some-group/some-project.git Using LDAP: yes Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 8.4.3 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
sudo gitlab-rake gitlab:check SANITIZE=true Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 8.4.3 ? ... OK (8.4.3) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: <REDACTED> LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) <REDACTED>
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 4/1 ... yes 3/2 ... yes 3/3 ... yes 3/4 ... yes 3/5 ... yes 3/6 ... yes 3/7 ... yes 3/8 ... yes 3/9 ... yes 3/10 ... yes 112/11 ... yes 9/12 ... yes 9/13 ... yes 6/16 ... yes 6/17 ... yes 6/18 ... yes 6/19 ... yes 6/20 ... yes 6/21 ... yes 6/22 ... yes 7/23 ... yes 7/24 ... yes 7/25 ... yes 7/26 ... yes 8/27 ... yes 8/28 ... yes 2/29 ... yes 2/30 ... yes 2/31 ... yes 5/32 ... yes 5/33 ... yes 5/34 ... yes 5/35 ... yes 7/36 ... yes 7/37 ... yes 9/39 ... yes 7/40 ... yes 7/42 ... yes 2/45 ... yes 7/46 ... yes 7/47 ... yes 5/48 ... yes 3/49 ... yes 9/50 ... yes 39/51 ... yes 7/52 ... yes 7/55 ... yes 70/56 ... yes 3/58 ... yes 7/59 ... yes 5/61 ... yes 39/62 ... yes 7/63 ... yes 5/66 ... yes 3/67 ... yes 7/68 ... yes 3/69 ... yes 17/70 ... yes 2/72 ... yes 7/73 ... yes 3/74 ... yes 7/75 ... yes 6/76 ... yes 11/77 ... yes 3/78 ... yes 17/79 ... yes 2/80 ... yes 2/81 ... yes 7/83 ... yes 7/84 ... yes 112/86 ... yes 3/87 ... yes 11/88 ... yes 112/89 ... yes 18/90 ... yes 5/91 ... yes 112/93 ... yes 112/94 ... yes 112/95 ... yes 112/96 ... yes 7/97 ... yes 7/98 ... yes 7/99 ... yes 5/100 ... yes 112/101 ... yes 7/102 ... yes 114/103 ... yes 114/105 ... yes 114/106 ... yes 114/107 ... yes 7/108 ... yes 7/110 ... yes 7/111 ... yes 7/112 ... yes 114/113 ... yes 114/114 ... yes 10/115 ... yes 112/116 ... yes 7/117 ... yes 124/118 ... yes 5/120 ... yes 112/121 ... yes 11/122 ... yes 5/124 ... yes 114/125 ... yes 7/126 ... yes 112/128 ... yes 76/129 ... yes 114/130 ... yes 136/131 ... yes 136/132 ... yes 136/133 ... yes 136/134 ... yes 136/135 ... yes 136/136 ... yes 136/137 ... yes 136/138 ... yes 136/139 ... yes 136/140 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.5.3) Git version >= 2.18.0 ? ... yes (2.18.1) Git user has default SSH configuration? ... yes Active users: ... 91
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
N/A