N+1 Gitaly calls to FindCommit in CommitsController#signatures
- ZenDesk: https://gitlab.zendesk.com/agent/tickets/111902
- GitLab 11.5.7
This was seen in the strace output when we tried to understand why CommitsController#signatures
(e.g. https://gitlab.com/gitlab-org/gitlab-ce/commits/master/signatures?format=json) was taking over 15 seconds to load for most users. For one request, we saw 107 requests for FindCommit
, which caused 107 git cat-file
processes to run.
Edited by Stan Hu