Include "outdated" discussions in the diff on the changes tabs

Problem to solve

Merge request discussions "disappear" from the changes tab after a new version that modifies the code is pushed.

Target audience

Software Developer

Further details

If I spot an error when reviewing code, I often want to ensure that the mistake is addressed in the updated version. Today, when I re-review the update, I need to start in the discussions tab, find the relevant change in the changes tab, and cross reference between them to ensure my feedback was executed on.

I have a team that currently uses collaberator for their review process. The biggest issue they have with GitLab merge requests is discussions stop showing up on the "changes" tab as later revisions mutate the discussion's code.

Proposal

I think the way GitLab works is when I add a comment to the new code, the comment is only keyed to that new code. As soon as the diff changes such that the new code is replaced, the discussion no longer shows up in the changes tab.

My proposal is that it keys off the new code, unless it's no longer in the current diff. In that scenerio it would fall back to keying off the original replaced code.

What does success look like, and how can we measure that?

Success would mean that the discussion that shows up here, also shows up here.

Links / references