Create: Activity filter only works on discussion tab

Summary

The Activity filter ("Show all activity") seems to only filter history or comments on the "Discussion" tab.

I'm not sure if this is a bug where it is not filtering other tabs or the filter should only appear on the discussion tab. If it's the latter it would be hugely helpful to be able to apply this filter to changes so I can do a code review without seeing all existing comments 😸. In that case, happy to follow this up with a feature request

Steps to reproduce

  1. Visit a merge request with outstanding comments and changes; i.e. gitlab-com/www-gitlab-com!17928 (diffs).
  2. Navigate to Changes tab
  3. Toggle "Show all activity" to "Show history only"

Example Project

gitlab-com/www-gitlab-com!17928 (merged)

What is the current bug behavior?

Activity filter does not apply to all tabs

What is the expected correct behavior?

Activity filter should allow filtering of history and/or comments on "Changes" tab.

Relevant logs and/or screenshots

Image_2019-01-09_at_16.36.50

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

N/A

Results of GitLab application Check

N/A

Possible fixes