Misleading pipeline tooltip messages AND misleading CI status icons on simple commits
Summary
The tooltip message for a failed pipeline on a commit is "Commit Failed". This is misleading, inaccurate, and creates confusion w.r.t. the success / failure of a commit.
Steps to reproduce
New project with auto-devops enabled. Push a commit to the repository. Pipeline fails (of course...I'm not sure why anyone would expect a new project to pass a generic auto-pipeline job run!). Go to the commits page and hover over the failed pipeline. The tooltip that is displayed is "Commit Failed".
Now I immediately interpreted that to mean there was a problem at the Git level with the repository commit. Phew...commit was fine...just a poorly worded pipeline failure tooltip message.
Example Project
Go to https://gitlab.com/BackStopThemes/ThemeCoreV2/commits/master and hover over the big red cross button top right on commit 8b946ec4. You'll see the troublesome tooltip message (or just look at the screenshot below).
What is the current bug behavior?
Pipeline failure on initial autodevops commit says "Commit Failed".
What is the expected correct behavior?
"Pipeline Failed"
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
N/A
Results of GitLab application Check
N/A
Possible fixes
Don't know which line of code it is. I did a GitLab global search but it got 0 search results match in the code.
Further information
This problem has been surfaced through the baseline experience recommendations effort of 2019 Q2: gitlab-design#518 (closed)