Missing clone URL on project page if Git access protocol is "HTTPS only"
Summary
When the Git access protocol is set to "HTTPS only", the clone URL is not accessible anymore on the project page.
Steps to reproduce
Set Enabled Git access protocols
to HTTPS only
in Admin Area > Settings > Visibility and access controls
. Go to any project page: instead of the clone pull-down menu, a large HTTPS
button is displayed. Clicking on the button has no effect.
Example Project
See https://gitlab.onelab.info/gmsh/gmsh/
What is the current bug behavior?
A large HTTPS button is displayed; clicking on it does not do anything:
What is the expected correct behavior?
A menu should also be displayed for HTTPS-only, with the clone URL. This is the menu that is displayed when both SSH and HTTPS are selected as Git protocols:
Relevant logs and/or screenshots
See above.
Output of checks
No checks.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.6 Bundler Version:1.16.6 Rake Version: 12.3.1 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.3 Go Version: unknownGitLab information Version: 11.6.1 Revision: 598c5a7 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.onelab.info HTTP Clone URL: https://gitlab.onelab.info/some-group/some-project.git SSH Clone URL: git@gitlab.onelab.info:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 8.4.3 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 8.4.3 ? ... OK (8.4.3) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... no Try fixing it: sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ; sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ; For more information see: doc/install/installation.md in section "GitLab" Please fix the error above and rerun the checks. Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/3 ... yes 2/4 ... yes 2/5 ... yes 2/10 ... yes 26/12 ... yes 26/13 ... yes 26/14 ... yes 26/16 ... yes 26/17 ... yes 26/18 ... yes 28/21 ... yes 50/23 ... yes 61/24 ... yes 61/25 ... yes 61/27 ... yes 61/28 ... yes 61/29 ... yes 28/31 ... yes 26/32 ... yes 1/34 ... yes 1/35 ... yes 29/36 ... yes 62/38 ... yes 40/39 ... yes 62/40 ... yes 40/42 ... yes 62/43 ... yes 62/44 ... yes 40/45 ... yes 40/46 ... yes 86/47 ... yes 86/49 ... yes 86/50 ... yes 40/51 ... yes 29/52 ... yes 28/54 ... yes 95/61 ... yes 39/65 ... yes 106/66 ... yes 106/67 ... yes 107/68 ... yes 108/69 ... yes 28/70 ... yes 19/71 ... yes 120/73 ... yes 120/74 ... yes 120/75 ... yes 122/76 ... yes 38/77 ... yes 18/78 ... yes 47/79 ... yes 86/80 ... yes 119/81 ... yes 39/83 ... yes 38/84 ... yes 62/85 ... yes 119/86 ... yes 2/87 ... yes 40/88 ... yes 2/89 ... yes 40/90 ... yes 26/92 ... yes 40/93 ... yes 39/94 ... yes 19/95 ... yes 40/96 ... yes 26/97 ... yes 29/100 ... yes 41/101 ... yes 41/102 ... yes 41/103 ... yes 261/104 ... yes 106/105 ... yes 106/106 ... yes 61/107 ... yes 13/108 ... yes 120/109 ... yes 51/110 ... yes 31/111 ... yes 392/112 ... yes 392/113 ... yes 392/114 ... yes 392/115 ... yes 392/116 ... yes 2/117 ... yes 87/119 ... yes 63/120 ... yes 392/121 ... yes 31/123 ... yes 40/124 ... yes 392/125 ... yes 61/126 ... yes 392/127 ... yes 2/129 ... yes 86/130 ... yes 2/132 ... yes 2/133 ... yes 2/139 ... yes 2/141 ... yes 2/142 ... yes 2/143 ... yes 623/144 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.5.3) Git version >= 2.18.0 ? ... yes (2.18.1) Git user has default SSH configuration? ... yes Active users: ... 370
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished