Global shortcuts still active while loading labels
Global shortcuts are still active while loading the ‘labels’ popover. This means that if I load the page to edit an issue, click ‘labels’ and start typing to search for a label before the popover has finished loading, all sorts of things will happen if my search term contains any global hotkeys (like ‘s’ for search).
Steps to reproduce
- Open or edit an issue
- Click the ‘labels’ entry to start loading the popover for selecting labels (either the one in the sidebar when viewing an issue, or the one on the main form when editing)
- Start typing a search term before it’s finished loading
- If the search term contains a hotkey like ‘s’, you’ll suddenly find yourself searching; other global shortcuts do similarly disruptive things
What is the current bug behavior?
Global shortcuts are activated.
What is the expected correct behavior?
Global shortcuts are not activated; typed text forms part of the search terms for a label.
Results of GitLab environment info
I don’t have access to this. We’re running GitLab 11.6.
Results of GitLab application Check
Don’t have access to this.
Disable the global shortcuts while the ‘labels’ popover is visible. Same for other popovers, like the milestone one. Pressing ‘esc’ should hide the popover (as it currently does) and restore the global shortcuts.