Create a list of Go reviewers
Problem to solve
Some GitLab teams maintaining Go-based projects may be in the situation where they don't have enough resourcess to review their own merge requests. We should share a pool of Go reviewers across teams.
Further details
The ~Secure team maintains many small projects written in Go but only has two developers with strong Go skills. When a MR is submitted there's usually a domain expert to review the behavior of the code, but no one to make sure this is good Go code.
Proposal
Publish a list of GitLab members having the skills to review Go code.
Go reviewers would ensure that the code is Go-idiomatic and follows the guidelines we're currently discussing in https://gitlab.com/gitlab-org/gitlab-ce/issues/54494.
To avoid expensive review rounds we would usually proceed in two steps:
- review by a domain expert focusing on the behavior of the code
- review by a seasoned Go developer focusing on the implementation
What does success look like, and how can we measure that?
GitLab teams maintaining Go projects can easily find a reviewer for their MRs.
Links / references
See also https://gitlab.com/gitlab-org/gitlab-ce/issues/54494
/cc @plafoucriere @nick.thomas @jacobvosmaer-gitlab @ayufan @tmaczukin @nolith @zj @SteveAzz