Can't unresolve resolved review on diff tab if it was started on the discussion tab
Summary
It's possible to get into a state where you can't unresolve a discussion on the diff tab. This happens to be the state a QA test ends up in, causing it to fail: gitlab-qa#354 (moved)
Possibly related to: https://gitlab.com/gitlab-org/gitlab-ce/issues/55245 ?
Steps to reproduce
- Start a non-diff discussion.
- Use the discussion to start a review with "Resolve discussion" checked.
- Switch to the diff tab and comment (via "Comment now").
- Reply to the comment using "Add to review" with "Resolve discussion" checked.
- Submit the review.
- Try to continue the discussion and unresolve it
Example Project
Any MR, e.g.: mlapierre/test!6 (closed)
What is the current bug behavior?
The discussion already appears unresolved (and the last comment doesn't appear: https://gitlab.com/gitlab-org/gitlab-ce/issues/55245).
Note that if you switch back to the discussions tab the discussion appears resolved as expected.
What is the expected correct behavior?
The discussion should appear resolved so that it can be unresolved.
Output of checks
This bug happens on GitLab.com