Correlation-IDs being passed through GRPC metadata are incorrect
The following discussion from !22844 (merged) should be addressed:
-
@andrewn started a discussion: 😞 I've just realised that this is wrong. It needs to match https://gitlab.com/gitlab-org/labkit/blob/master/correlation/grpc/key.go#L3:X-GitLab-Correlation-ID
.This is the key that's already being used to send correlation-ids between Workhorse and Gitaly, and also between Gitaly and Gitaly-Ruby.
I'll send a MR for it.
In !22844 (merged), GitLab's Ruby components are sending the correlation-id from Ruby via the GRPC correlation_id
header.
However, Workhorse and Gitaly are already using the header X-GitLab-Correlation-ID
for this purpose.
I suggest we update the field in Ruby to match the one already being used in Workhorse and Gitaly.