Commit e-mail in profile settings defaults to private
First noticed by @rspeicher in Slack (https://gitlab.slack.com/archives/C02PF508L/p1542217088521700):
It looks like the array generated by commit_email_select_options
is wrong in https://gitlab.com/gitlab-org/gitlab-ce/blob/2059e9f521c57d879002b16ccba3b7ed29996840/app/views/profiles/show.html.haml#L95:
irb(main):010:0> selected_commit_email(u)
=> "stanhu@example.com"
irb(main):011:0> commit_email_select_options(u)
=> [["Use a private email - 64248-stanhu@users.noreply.gitlab.com", "_private"], ["stanhu@example.com", "stan@domain.com"]]
Edited by Stan Hu