Merge request UI hook output is not showing.

Summary

Merge request update hook output is not showing up just the merge button again and that something went wrong. This seems to be a UI issue. All the checks run in the update hook fine, it produces a printout, the printout is visible in production.log being transformed into HTML and is simply missing from the UI. This way the developer would receive no reason why the merge failed and that would be an 'Ooops something happened' type of shitty response. The documentation says this feature has been developed and it should show up but apparently at some point it may have been unmerged from gitlab by some later UI changes.

Steps to reproduce

  • create update hook
  • commit stuff(make sure the update hook fails on the target branch later)
  • create merge request
  • try to merge it.

Example Project

No file system access here sorry...

What is the current bug behavior?

Something went wrong and Merge button reactivates

What is the expected correct behavior?

The output of the failing hooks

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

Expand for output related to GitLab environment info

System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.1 Go Version: unknown

GitLab information Version: 11.4.0 Revision: 6ebbd70 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.tooling-dev.private.qwil.network HTTP Clone URL: https://gitlab.tooling-dev.private.qwil.network/some-group/some-project.git SSH Clone URL: git@gitlab.tooling-dev.private.qwil.network:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers:

GitLab Shell Version: 8.3.3 Repository storage paths:

  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git