Refactor `has_many :deployments, -> { success }` to `has_one :deployment`
Problem
This is a follow-up from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22380/diffs#about-has_many-deployments-success-. Today we have the following methods in Project
, Environment
and Ci::Build
models.
has_many :deployments, -> { success } # Successful `deployments` records
has_one :last_deployment, -> { success } # The last successful `deployments` record
has_one :real_last_deployment # The last `deployments` record
However, identically those methods should be
has_one :deployment # The last `deployments` record
has_one :successful_deployment, -> { success } # The last `deployments` record