Project /runners API lies about active runners
Summary
The project runners API lies about the active runners for that project.
It's arguable that the Web UI is also incorrect (or at least very ambiguous).
Steps to reproduce
- Create a project
- Enable shared runners for the project and ensure that there is at least one shared runner.
- (Optional) Assign a group runner to the group in which the project lives, and ensure group runners are enabled for the project.
- Assign a specific runner to the project.
GET /projects/:id/runners
- Observe all three runners in the JSON
✅
- Click the orange
Disable shared runners
button. It will change to green and readEnable shared runners
.
- This implies that shared runners are disabled. (UX: This is very confusing, and GitLab should use the toggle switch control which is much less ambiguous!)
- (Optional) Click the orange-outline
Disable group runners
button. It will change to green-outline and readEnable group runners
.
- Same note as above
What is the current bug behavior?
GET /projects/:id/runners
- Observe all three runners are still in the JSON and marked
"active": true
❌
What is the expected correct behavior?
GET /projects/:id/runners
- Observe the shared runners and group runners are missing
Results of GitLab environment info
Version: GitLab ce 11.3.4 (30f019d)