Include merge request reference in closed issue email
Problem to solve
Receiving an email notification about an issue that was closed by a merge request using the issue closing pattern is missing a reference to the related merge request. This would be helpful for all the issues you've suscribed to but haven't subscribed to the relevant merge request that will automatically close the issue.
Proposal
Change the current email structure to something like the following:
diff --git a/app/views/notify/closed_issue_email.html.haml b/app/views/notify/closed_issue_email.html.haml
index b7284dd819b..62c7a7f2d93 100644
--- a/app/views/notify/closed_issue_email.html.haml
+++ b/app/views/notify/closed_issue_email.html.haml
@@ -1,2 +1,6 @@
-%p
- Issue was closed by #{@updated_by.name}
+- if @closed_by_merge_requests.present?
+ %p
+ Issue was closed by #{@updated_by.name} via merge request #{@merge_request.to_reference}
+- else
+ %p
+ Issue was closed by #{@updated_by.name}
What does success look like, and how can we measure that?
Users are clicking on the merge request referece via email.
Edited by George Tsiolis