Merge request review mode: file by file diff view

The file tree makes reviewing a set of changes easier, but I still find myself getting lost scrolling around changes to a file that are larger than a single screen. I'm accustomed to being able flick my mouse/trackpad in my editor to jump to the bottom or top of a file, but this doesn't work in the diff, I end up lost on a very long page.

Proposal

  • Entering the changes tab collapses the merge request description.
  • Only one diff is shown at a time.
  • Add keyboard navigation to jump between files
    • n / p (or [ / ])
    • Space at the bottom of a file will jump to next file
  • Always present review comments (batch comments)

Links / references

Edited Oct 12, 2018 by James Ramsay (ex-GitLab)
Assignee Loading
Time tracking Loading