Remove inaccessible events from the `EventsFinder`s
The EventsFinder
currently includes events the current_user
does not actually have access to. It only checks access to the project. While ignoring access to the feature or issue confidentiality.
This means that we were exposing those events in the API, causing this issue gitlab-com/gl-infra/production#477 (closed).
We started working on a way to exclude those events from the finder by building complicated queries in: https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2511 but that turned out to be to complicated for an upcoming security release, so we redacted the events exposed in the API instead: https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2514
Now we need to actually remove those events from loaded results.