Gitlab UI components should not be registered globally
Gitlab UI components should not be registered globally because it will make code splitting super hard - we won't need a progress bar every where but it will be in the main bundle which will increase size and decrease performance. This also make it super hard to debug code.
Slack discussion link https://gitlab.slack.com/archives/C0GQHHPGW/p1537454510000100 Slack discussion:
filipa [1 hour ago]
Is there an issue for this?
leipert [30 minutes ago]
I wondered the same :slightly_smiling_face:
filipa [29 minutes ago]
I commented it here too https://gitlab.com/gitlab-org/gitlab-ce/commit/6709cfc61b8402734959496f6cc0120cc1aa98a7#note_103143951 (edited)
filipa [29 minutes ago]
I'll open an issue if there isn't one already
filipa [28 minutes ago]
this doesn't make a lot of sense to me but I may be missing something.
winnie [22 minutes ago]
I think we would safe some imports and additions to `components: { ... }` that way and thus keep our code base more focused on the bigger parts.
But I’m not sure if that’s worth it. (edited)
mgreiling [15 minutes ago]
I’m not a fan of globally registering components, primarily for this reason. I also think it makes debugging more difficult.
filipa [1 minute ago]
yes it does. I spend a few minutes trying to understand where were things coming from :disappointed:
Let me open an issue and move this discussion there
cc @timzallmann @ClemMakesApps @mikegreiling @iamphill @leipert @winh
I'd label as a bug, but I don't think it qualifies, although this does decrease performance and makes debugging harder.