Base64 embedding of images in notification mails
Images in notification E-Mails are not embedded but only link to the uploaded file which
- Is a privacy issue and some email clients block them
- Does not work for non-publicly available gitlab instances behind firewalls
-
Frankly, I consider it a security issue that an email client can display them without being logged in: gitlab-org/gitlab-ce#51503 (and logging in in the email client would not be possible)Edit: though this is still my personal opinion, this has been determined to "work as expected" by Gitlab engineers - Also does not work for Gitlab-specific assets of an instance between a firewall like e.g. icons: gitlab-org/gitlab-ce#24859
The solution would be to embed all images into the mails directly.
- This feature seems to have been implemented in !373 (merged) but it is broken again.
- The request has already been posted here some time ago: https://forum.gitlab.com/t/images-arent-showing-in-emails/6836
Edited by Philipp Hasper