undefined method `absolute_path' for AvatarUploader
Summary
After upgrading from 11.2.1 to 11.2.3 and using Custom project templates where the project has an avatar fails.
If using a new install of 11.2.3 then it works correctly.
Steps to reproduce
Setup
- Install 11.2.1
- Create projects with/without avatars in a group which is used as the custom project template source group
- Upgrade to 11.2.3
Example Project
What is the current bug behavior?
Import error
Import/Export error raised on /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:24:in `rescue in save': undefined method `absolute_path' for #<AvatarUploader:0x00007f1be9d59a10>
Import/Export backtrace: /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:56:in `block in copy_project_uploads'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:77:in `each_uploader'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:50:in `copy_project_uploads'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:20:in `save'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/avatar_saver.rb:19:in `save'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:33:in `each'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:33:in `all?'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:33:in `save_services'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:24:in `save_all!'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:9:in `execute'
What is the expected correct behavior?
Import works correctly.
Relevant logs and/or screenshots
/var/log/gitlab/gitlab-rails/production.log
Import/Export error raised on /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:24:in `rescue in save': undefined method `absolute_path' for #<AvatarUploader:0x00007f1be9d59a10>
Import/Export backtrace: /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:56:in `block in copy_project_uploads'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:77:in `each_uploader'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:50:in `copy_project_uploads'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/uploads_manager.rb:20:in `save'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/avatar_saver.rb:19:in `save'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:33:in `each'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:33:in `all?'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:33:in `save_services'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:24:in `save_all!'
/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:9:in `execute'
/opt/gitlab/embedded/service/gitlab-rails/app/workers/project_export_worker.rb:14:in `perform'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:187:in `execute_job'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:169:in `block (2 levels) in process'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:128:in `block in invoke'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_status/server_middleware.rb:5:in `call'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/request_store_middleware.rb:6:in `call'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/shutdown.rb:52:in `call'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/sidekiq_middleware.rb:13:in `block in call'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/transaction.rb:53:in `run'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/sidekiq_middleware.rb:13:in `call'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/server/active_record.rb:16:in `call'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sentry-raven-2.7.2/lib/raven/integrations/sidekiq.rb:9:in `call'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:133:in `invoke'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:168:in `block in process'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:139:in `block (6 levels) in dispatch'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/job_retry.rb:98:in `local'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:138:in `block (5 levels) in dispatch'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq.rb:36:in `block in <module:Sidekiq>'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:134:in `block (4 levels) in dispatch'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:199:in `stats'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:129:in `block (3 levels) in dispatch'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/job_logger.rb:8:in `call'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:128:in `block (2 levels) in dispatch'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/job_retry.rb:73:in `global'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:127:in `block in dispatch'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/logging.rb:48:in `with_context'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/logging.rb:42:in `with_job_hash_context'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:126:in `dispatch'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:167:in `process'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:85:in `process_one'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:73:in `run'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/util.rb:16:in `watchdog'
/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/util.rb:25:in `block in safe_thread'
sidekiq.log
2018-09-05_04:56:08.85258 2018-09-05T04:56:08.852Z 520 TID-orpxqiyuc ProjectExportWorker JID-6f6bdc46e36d4ce2bf8b7145 INFO: start
2018-09-05_04:56:09.00490 2018-09-05T04:56:09.004Z 520 TID-orpxqixuk ActionMailer::DeliveryJob JID-3e04b448c82b790e6a7926f5 INFO: start
2018-09-05_04:56:09.00827 2018-09-05T04:56:09.008Z 520 TID-orpxqiyuc ProjectExportWorker JID-6f6bdc46e36d4ce2bf8b7145 INFO: Adding dead ProjectExportWorker job 6f6bdc46e36d4ce2bf8b7145
2018-09-05_04:56:09.00948 2018-09-05T04:56:09.009Z 520 TID-orpxqiyuc ProjectExportWorker JID-6f6bdc46e36d4ce2bf8b7145 INFO: fail: 0.157 sec
2018-09-05_04:56:09.00994 2018-09-05T04:56:09.009Z 520 TID-orpxqiyuc WARN: {"context":"Job raised exception","job":{"class":"ProjectExportWorker","args":[1,2,{"export_into_project_id":7,"klass":"EE::Gitlab::ImportExport::AfterExportStrategies::CustomTemplateExportImportStrategy"},{}],"retry":3,"queue":"project_export","backtrace":5,"jid":"6f6bdc46e36d4ce2bf8b7145","created_at":1536123231.2680337,"enqueued_at":1536123368.8513982,"error_message":"undefined method `absolute_path' for #<AvatarUploader:0x00007f1be678e5e8>","error_class":"Gitlab::ImportExport::Error","failed_at":1536123231.5852342,"retry_count":2,"error_backtrace":["/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:75:in `cleanup_and_notify_error!'","/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:28:in `save_all!'","/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:9:in `execute'","/opt/gitlab/embedded/service/gitlab-rails/app/workers/project_export_worker.rb:14:in `perform'","/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:187:in `execute_job'"],"retried_at":1536123301.1777668},"jobstr":"{\"class\":\"ProjectExportWorker\",\"args\":[1,2,{\"export_into_project_id\":7,\"klass\":\"EE::Gitlab::ImportExport::AfterExportStrategies::CustomTemplateExportImportStrategy\"},{}],\"retry\":3,\"queue\":\"project_export\",\"backtrace\":5,\"jid\":\"6f6bdc46e36d4ce2bf8b7145\",\"created_at\":1536123231.2680337,\"enqueued_at\":1536123368.8513982,\"error_message\":\"undefined method `absolute_path' for #<AvatarUploader:0x00007f1be678e5e8>\",\"error_class\":\"Gitlab::ImportExport::Error\",\"failed_at\":1536123231.5852342,\"retry_count\":2,\"error_backtrace\":[\"/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:75:in `cleanup_and_notify_error!'\",\"/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:28:in `save_all!'\",\"/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:9:in `execute'\",\"/opt/gitlab/embedded/service/gitlab-rails/app/workers/project_export_worker.rb:14:in `perform'\",\"/opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:187:in `execute_job'\"],\"retried_at\":1536123301.1777668}"}
2018-09-05_04:56:09.01200 2018-09-05T04:56:09.009Z 520 TID-orpxqiyuc WARN: Gitlab::ImportExport::Error: undefined method `absolute_path' for #<AvatarUploader:0x00007f1be9d59a10>
2018-09-05_04:56:09.01237 2018-09-05T04:56:09.009Z 520 TID-orpxqiyuc WARN: /opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_export/export_service.rb:75:in `cleanup_and_notify_error!'
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.11 Git Version: 2.18.0 Sidekiq Version:5.1.3 Go Version: unknownGitLab information Version: 11.2.3-ee Revision: aadca99 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.8 URL: http://gitlab-ee-11-2-1 HTTP Clone URL: http://gitlab-ee-11-2-1/some-group/some-project.git SSH Clone URL: git@gitlab-ee-11-2-1:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: no
GitLab Shell Version: 8.1.1 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...
GitLab Shell version >= 8.1.1 ? ... OK (8.1.1) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 2/1 ... ok 2/2 ... ok 1/3 ... ok 1/4 ... ok 1/5 ... ok 1/6 ... ok 1/7 ... repository is empty Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/1 ... yes 2/2 ... yes 1/3 ... yes 1/4 ... yes 1/5 ... yes 1/6 ... yes 1/7 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.18.0) Git user has default SSH configuration? ... yes Active users: ... 1 Elasticsearch version 5.1 - 5.5? ... skipped (elasticsearch is disabled)
Checking GitLab ... Finished