[Documentation] gitlab stop before backup in the upgrade doc, to change?
Update of documentation for "upgrade from source" for Community Edition (and apparently also Enterprise Edition)
-
Update existing documentation https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/update/11.0-to-11.1.md and later
It seems to me that stopping gitlab before proceeding with the backup is not appropriate anymore. Since a couple of versions (sorry I've not kept trace of which one), the backup fails (with itlab::Git::CommandError: 14:Connect Failed
) if gitlab is stopped and runs fine if gitlab is not stopped.
I would therefore recommend, in the upgrade documentation, to fist backup and then stop gitlab.
If some people confirm that I am correct and I am no saying something silly, I will be happy to submit a merge request with the updated documentation.
Edited by PAB