System hooks are fired twice upon repository updates
Noticed while investigating https://gitlab.com/gitlab-com/production/issues/431.
We run a system hook here upon a push:
Then we run it again here:
- https://gitlab.com/gitlab-org/gitlab-ce/blob/382b6dabd96e8966386729d82854b899ad4ce894/app/services/git_push_service.rb#L144
- https://gitlab.com/gitlab-org/gitlab-ce/blob/382b6dabd96e8966386729d82854b899ad4ce894/app/models/project.rb#L1192
This can lead to unnecessary memory usage and add to slow Redis performance.
Edited by Stan Hu