500 Internal Server Error: Edit a snippet and set empty code

Summary

500 Internal Server Error: Edit snippet and set empty code

Steps to reproduce

1. Create a project
2. Create a snippet
3. Edit snippet to have empty code

Sample curl:

curl -v -X 'PUT'  -H "Content-Type: application/json" -H 'PRIVATE-TOKEN: juDvZNgjFyzz_pByLW8W' 'http://127.0.0.1/api/v4/projects/59836/snippets/441' -d '{"title":"bla title", "file_name":"bla filename", "code":"","visibility":"public"}' 

Example Project

Bug is reproducible in a local deployment, source code installation of EE on 11-2-stable branch.

What is the current bug behavior?

500 Internal Server Error

What is the expected correct behavior?

Some 40x error message.

Relevant logs and/or screenshots

ActiveRecord::UnknownAttributeError (unknown attribute 'code' for ProjectSnippet.):
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:59:in `rescue in _assign_attribute'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:54:in `_assign_attribute'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:41:in `block in assign_attributes'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:35:in `each'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.10/lib/active_record/attribute_assignment.rb:35:in `assign_attributes'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/attr_encrypted-3.1.0/lib/attr_encrypted/adapters/active_record.rb:28:in `perform_attribute_assignment'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/attr_encrypted-3.1.0/lib/attr_encrypted/adapters/active_record.rb:36:in `assign_attributes'
  /home/git/gitlab/app/services/update_snippet_service.rb:25:in `execute'
  /home/git/gitlab/lib/api/project_snippets.rb:100:in `block (2 levels) in <class:ProjectSnippets>'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/endpoint.rb:57:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/endpoint.rb:57:in `block (2 levels) in generate_api_method'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/notifications.rb:166:in `instrument'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/endpoint.rb:56:in `block in generate_api_method'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/endpoint.rb:262:in `block in run'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/notifications.rb:166:in `instrument'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/endpoint.rb:243:in `run'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/endpoint.rb:313:in `block in build_stack'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/base.rb:31:in `call!'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/base.rb:24:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/base.rb:31:in `call!'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/base.rb:24:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-oauth2-1.2.3/lib/rack/oauth2/server/resource.rb:20:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-oauth2-1.2.3/lib/rack/oauth2/server/resource/bearer.rb:8:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/error.rb:37:in `block in call!'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/error.rb:36:in `catch'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/error.rb:36:in `call!'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/base.rb:24:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape_logging-1.7.0/lib/grape_logging/middleware/request_logger.rb:60:in `block in call!'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape_logging-1.7.0/lib/grape_logging/middleware/request_logger.rb:58:in `catch'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape_logging-1.7.0/lib/grape_logging/middleware/request_logger.rb:58:in `call!'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/middleware/base.rb:24:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/head.rb:13:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/endpoint.rb:227:in `call!'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/endpoint.rb:221:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/router/route.rb:72:in `exec'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/router.rb:121:in `process_route'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/router.rb:74:in `block in identity'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/router.rb:93:in `transaction'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/router.rb:72:in `identity'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/router.rb:57:in `block in call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/router.rb:137:in `with_optimization'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/router.rb:56:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/api.rb:119:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/api.rb:45:in `call!'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-1.0.3/lib/grape/api.rb:40:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/routing/mapper.rb:51:in `serve'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/journey/router.rb:43:in `block in serve'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/journey/router.rb:30:in `each'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/journey/router.rb:30:in `serve'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/routing/route_set.rb:817:in `call'
  /home/git/gitlab/lib/gitlab/middleware/multipart.rb:97:in `call'
  /home/git/gitlab/lib/gitlab/request_profiler/middleware.rb:14:in `call'
  /home/git/gitlab/lib/gitlab/middleware/go.rb:17:in `call'
  /home/git/gitlab/lib/gitlab/etag_caching/middleware.rb:11:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/batch-loader-1.2.1/lib/batch_loader/middleware.rb:11:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-attack-4.4.1/lib/rack/attack.rb:107:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/warden-1.2.7/lib/warden/manager.rb:36:in `block in call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/warden-1.2.7/lib/warden/manager.rb:35:in `catch'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/warden-1.2.7/lib/warden/manager.rb:35:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-cors-1.0.2/lib/rack/cors.rb:97:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/etag.rb:24:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/conditionalget.rb:38:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/head.rb:13:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/params_parser.rb:27:in `call'
  /home/git/gitlab/lib/gitlab/middleware/read_only/controller.rb:38:in `call'
  /home/git/gitlab/lib/gitlab/middleware/read_only.rb:16:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/flash.rb:260:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/session/abstract/id.rb:225:in `context'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/session/abstract/id.rb:220:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/cookies.rb:560:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.10/lib/active_record/query_cache.rb:36:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.10/lib/active_record/connection_adapters/abstract/connection_pool.rb:653:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:88:in `__run_callbacks__'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:778:in `_run_call_callbacks'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/callbacks.rb:81:in `run_callbacks'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/remote_ip.rb:78:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
  /home/git/gitlab/lib/gitlab/middleware/basic_health_check.rb:25:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.10/lib/rails/rack/logger.rb:38:in `call_app'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.10/lib/rails/rack/logger.rb:20:in `block in call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/tagged_logging.rb:68:in `block in tagged'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/tagged_logging.rb:26:in `tagged'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.10/lib/active_support/tagged_logging.rb:68:in `tagged'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.10/lib/rails/rack/logger.rb:20:in `call'
  /home/git/gitlab/lib/gitlab/request_context.rb:18:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/request_store-1.3.1/lib/request_store/middleware.rb:9:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.10/lib/action_dispatch/middleware/request_id.rb:21:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/methodoverride.rb:22:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/runtime.rb:18:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/lock.rb:17:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/sendfile.rb:113:in `call'
  /home/git/gitlab/lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/sentry-raven-2.7.2/lib/raven/integrations/rack.rb:51:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.10/lib/rails/engine.rb:518:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.10/lib/rails/application.rb:165:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.10/lib/rails/railtie.rb:194:in `public_send'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.10/lib/rails/railtie.rb:194:in `method_missing'
  /home/git/gitlab/lib/gitlab/middleware/release_env.rb:10:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/urlmap.rb:66:in `block in call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/urlmap.rb:50:in `each'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.10/lib/rack/urlmap.rb:50:in `call'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:562:in `process_client'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-worker-killer-0.4.4/lib/unicorn/worker_killer.rb:52:in `process_client'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:658:in `worker_loop'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:508:in `spawn_missing_workers'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:132:in `start'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/bin/unicorn_rails:209:in `<top (required)>'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/bin/unicorn_rails:22:in `load'
  /home/git/gitlab/vendor/bundle/ruby/2.3.0/bin/unicorn_rails:22:in `<top (required)>'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/cli/exec.rb:74:in `load'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/cli/exec.rb:74:in `kernel_load'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/cli/exec.rb:28:in `run'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/cli.rb:424:in `exec'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/cli.rb:27:in `dispatch'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/cli.rb:18:in `start'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/exe/bundle:30:in `block in <top (required)>'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/lib/bundler/friendly_errors.rb:124:in `with_friendly_errors'
  /usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.16.2/exe/bundle:22:in `<top (required)>'
  /usr/local/bin/bundle:22:in `load'
  /usr/local/bin/bundle:22:in `<main>'