Merge request CI pipelines not accessible for private fork
Summary
Inspecting Gitlab CI logs and Pipelines of MRs from private repos is currently broken, and shows weird behaviour.
Steps to reproduce
Create a Project, let somebody else create a private fork of it, and ask him to open a PR with a Gitlab CI pipeline. Access the created merge request, try to look at Gitlab CI logs and pipelines.
What is the current bug behavior?
Thanks to #31847 (closed), commit links inside a MR point to a url within the MR context:
Clicking on one of the green checkboxes in above image brings me to this page:
The spinning wheel keeps spinning, but nothing is shown.
Back in the merge request, clicking on the Pipelines tab, I do see all pipelines:
But expanding one of these opens only empty space, and shows the "Something went wrong on our end." message bar:
What is the expected correct behavior?
Similar to #31141 (closed), CI-related resources should be shown in scope of the MR, so reviewers with access to the upstream repo can peek at CI builds.
Relevant logs and/or screenshots
See above
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 9.5 Current User: git Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.11 Git Version: 2.17.1 Sidekiq Version:5.1.3 Go Version: unknownGitLab information Version: 11.1.4 Revision: 63daf37 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.xxxxxxx.com HTTP Clone URL: https://gitlab.xxxxxxx.com/some-group/some-project.git SSH Clone URL: git@gitlab.xxxxxxx.com:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: saml
GitLab Shell Version: 7.1.4 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 7.1.4 ? ... OK (7.1.4) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 26/1 ... ok 26/2 ... ok 26/3 ... ok 26/4 ... ok 13/5 ... ok 10/6 ... ok 15/8 ... ok 2/9 ... ok 15/10 ... ok 25/11 ... ok 15/12 ... ok 26/13 ... ok 24/14 ... ok 10/15 ... ok 13/16 ... ok 22/17 ... ok 32/18 ... ok 12/19 ... ok 16/21 ... ok 12/22 ... ok 38/23 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 26/1 ... yes 26/2 ... yes 26/3 ... yes 26/4 ... yes 13/5 ... yes 10/6 ... yes 15/8 ... yes 2/9 ... yes 15/10 ... yes 25/11 ... yes 15/12 ... yes 26/13 ... yes 24/14 ... yes 10/15 ... yes 13/16 ... yes 22/17 ... yes 32/18 ... yes 12/19 ... yes 16/21 ... yes 12/22 ... yes 38/23 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.17.1) Git user has default SSH configuration? ... yes Active users: ... 24
Checking GitLab ... Finished