Node 6.0.0 LTS does not work for upgrade from 10.8 to 11.0

Had installed Node v 6.11.2

And was following: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/update/10.8-to-11.0.md

When compiling the assets with:

sudo -u git -H bundle exec rake yarn:install gitlab:assets:clean gitlab:assets:compile RAILS_ENV=production NODE_ENV=production

I got the the following error:

/home/git/gitlab/node_modules/monaco-editor-webpack-plugin/index.js:40
    [id, ...(language.alias || [])].map((label) => [label, { label, ...language }])
                                                                    ^^^

SyntaxError: Unexpected token ...
    at NativeCompileCache._moduleCompile (/home/git/gitlab/node_modules/v8-compile-cache/v8-compile-cache.js:226:18)
    at Module._compile (/home/git/gitlab/node_modules/v8-compile-cache/v8-compile-cache.js:172:36)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (/home/git/gitlab/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/home/git/gitlab/config/webpack.config.js:7:29)
    at Module._compile (/home/git/gitlab/node_modules/v8-compile-cache/v8-compile-cache.js:178:30)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (/home/git/gitlab/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at WEBPACK_OPTIONS (/home/git/gitlab/node_modules/webpack-cli/bin/convert-argv.js:133:13)
    at requireConfig (/home/git/gitlab/node_modules/webpack-cli/bin/convert-argv.js:135:6)
    at /home/git/gitlab/node_modules/webpack-cli/bin/convert-argv.js:142:17
    at Array.forEach (native)
    at module.exports (/home/git/gitlab/node_modules/webpack-cli/bin/convert-argv.js:140:15)
    at yargs.parse.err (/home/git/gitlab/node_modules/webpack-cli/bin/cli.js:241:39)
    at Object.parse (/home/git/gitlab/node_modules/webpack-cli/node_modules/yargs/yargs.js:552:18)
    at /home/git/gitlab/node_modules/webpack-cli/bin/cli.js:219:8
    at Object.<anonymous> (/home/git/gitlab/node_modules/webpack-cli/bin/cli.js:530:3)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/git/gitlab/node_modules/webpack/bin/webpack.js:157:2)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
rake aborted!

And a quick google search led me to:

https://github.com/Microsoft/monaco-editor-webpack-plugin/issues/21

Which states that monaco-editor-webpack-plugin does not support Object spread.

Fixed by updating to node v8.11.3

The docs should be updated accordingly (I'm not sure which node version supports Object spread)

Assignee Loading
Time tracking Loading