Follow-up from "WIP: Initial Commit on 48640"
The following discussions from !20771 should be addressed:
Should this be 'returns to previous assignee', instead?
I think we could just check if this is a merge request, as those don't support multiple assignees.
Yes, this does work.
If I had more time, I would have found a way to allow the Interpret Service to send a parameter, without it being present in the comment. This would have allowed the intended use case "/pong" to be possible.
Does this mean that
/assign assignerworks, but you need to type
This now works with "/pong" alone.
- Could we break this over multiple lines, please?
- What if the user assigned this to themselves?
- Should we restrict this to system notes, with the
systemscope? (Otherwise I could add a comment of 'assigned to @oswaldo' and this would find that.)
- What if there is no matching note?
If there is no matching note, the block will return nil, but will not be parsed, due to the ||= operator used to retrieve the value. I amended the issuable to use the system scope. Self assignation is irrelevant to the feature, because the previous assignee is by definition, not yourself (author_id != current_user.id).
QuickAction -> quick action
issuables -> issues and merge requests? (As this is user facing.)
Is this meant to be
Correct, it was meant to be "not_to".