Lacking test for Gitlab::Git::Repository#update_branch
In https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6445 ee/app/services/projects/update_mirror_service.rb
caught a typo in https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/80605132
NameError:
undefined local variable or method `gitaly_operations_client' for #<Gitlab::Git::Repository:0x000055f33e07d9b0>
Did you mean? gitaly_operation_client
@gitaly_operation_client
A fix was applied in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6445/diffs?commit_id=bc523d96d3e3836ccfc03d7aeee15e8c7adbde5c
However we have the same issue in CE: https://gitlab.com/gitlab-org/gitlab-ce/blob/f5f5a4e6775e4b8dd4cfeea45e026918f7b2a4d3/lib/gitlab/git/repository.rb#L630
We need to:
- Fix CE
- Add a test which could catch this