Undefined omniauth_authorize_path when omniauth_enabled not enabled
ZD: https://gitlab.zendesk.com/agent/tickets/99410
This is related to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20132. Customer had this in the config:
gitlab_rails['omniauth_auto_sign_in_with_provider'] = 'saml'
They got:
NoMethodError (undefined method `omniauth_authorize_path' for #<SessionsController:0x00007fb7e8236bb0>
Did you mean? omniauth_error_path):
app/controllers/sessions_controller.rb:158:in `auto_sign_in_with_provider'
lib/gitlab/i18n.rb:50:in `with_locale'
lib/gitlab/i18n.rb:56:in `with_user_locale'
app/controllers/application_controller.rb:370:in `set_locale'
lib/gitlab/middleware/multipart.rb:95:in `call'
lib/gitlab/request_profiler/middleware.rb:14:in `call'
ee/lib/gitlab/jira/middleware.rb:15:in `call'
lib/gitlab/middleware/go.rb:17:in `call'
lib/gitlab/etag_caching/middleware.rb:11:in `call'
lib/gitlab/middleware/read_only/controller.rb:28:in `call'
lib/gitlab/middleware/read_only.rb:16:in `call'
lib/gitlab/request_context.rb:18:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'
lib/gitlab/middleware/release_env.rb:10:in `call'
Setting omniauth_enabled
to true
worked around the problem.
Again, shouldn't we just load Omniauth completely in any case or check Gitlab.config.omniauth.auto_sign_in_with_provider.present?
?
/cc: @godfat
Edited by Stan Hu