"Merged by ___" committer is missing after use of GitHub Importer
Summary
The Merged By
field has an empty value after we imported a project from GitHub using the GitHub Importer.
See craftyguy/networkd-dispatcher!36 (merged) for example.
Steps to reproduce
Try importing https://github.com/craftyguy/networkd-dispatcher for example. (Hi, @craftyguy, I'm using you as an example.) Then, check the list of merge requests.
What is the current bug behavior?
When the page is rendered an <a>
tag is written into the document, with class="author-link ..."
, but it doesn't have a value inside it.
What is the expected correct behavior?
Some value should be there, at least 'unknown value' or 'github importer'.
Obviously if the user's GitHub account is known and linked to GitLab, then the GitLab account can be used.
If the accounts aren't linked, why not just link to their GitHub profile?
GitHub doesn't always link a committer to a GitHub account. I think they display a name or email address in that situation. (This happens when somebody makes commits using git-scm, outside of github, and they get merged in later.) I recommend doing what GitHub does on this one.
Output of checks
This bug happens on GitLab.com