You need to sign in or sign up before continuing.
Protect data by making `Project#rename_repo` more robust to exceptions
Work on the GCP migration has revealed that data is occasionally lost due to this class of problem: https://gitlab.com/gitlab-com/migration/issues/465
Existing code: https://gitlab.com/gitlab-org/gitlab-ce/blob/v10.8.3/app/models/project.rb#L1536-1546
It should rollback and reverse side-effects on errors, like Projects::TransferService
: https://gitlab.com/gitlab-org/gitlab-ce/blob/v10.8.3/app/services/projects/transfer_service.rb
There are too many things that can go wrong during a Project move, and GitLab.com sees hundreds (I think) of renames per day. We can make the overall approach more robust to protect customer data integrity when exceptions occur.