Skip to content

<br> got not decoded

Summary

As seen in the screenshot above the <br> HTML tag didn't get decoded

Steps to reproduce

This issue was only showing up on me on the incident of 3th May 2018. As explained in the screenshot make the internal API unreachable?!

Example Project

Seen on https://gitlab.com/xolf/homeworker/merge_requests/1753

What is the current bug behavior?

Showing the <br> tag in the text

What is the expected correct behavior?

Make a linebreak

Relevant logs and/or screenshots

Screenshot

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

As far as I know Gitlab is using Vue.js and for security reasons Vue.js didn't convert HTML tags in variable bindings. So using the v-html directive would fix it.