Resolve the offenses to the FactoriesInMigrationSpecs cop

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18108 introduced a new FactoriesInMigrationSpecs cop and we ignored the current offenses at this time, but we should address them properly and remove the disabling comments.

  1. ee/spec/lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb
  2. ee/spec/lib/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb
  3. ee/spec/lib/gitlab/background_migration/update_authorized_keys_file_since_spec.rb
  4. ee/spec/migrations/delete_inconsistent_internal_id_records_spec.rb
  5. ee/spec/migrations/update_authorized_keys_file_spec.rb
  6. spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb
  7. spec/lib/gitlab/background_migration/create_gpg_key_subkeys_from_gpg_keys_spec.rb
  8. spec/lib/gitlab/background_migration/delete_diff_files_spec.rb
  9. spec/lib/gitlab/background_migration/deserialize_merge_request_diffs_and_commits_spec.rb
  10. spec/lib/gitlab/background_migration/migrate_events_to_push_event_payloads_spec.rb
  11. spec/lib/gitlab/background_migration/migrate_system_uploads_to_new_folder_spec.rb
  12. spec/lib/gitlab/background_migration/move_personal_snippet_files_spec.rb
  13. spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb
  14. spec/lib/gitlab/background_migration/populate_merge_request_metrics_with_events_data_spec.rb
  15. spec/migrations/add_foreign_keys_to_todos_spec.rb
  16. spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb
  17. spec/migrations/calculate_conv_dev_index_percentages_spec.rb
  18. spec/migrations/cleanup_nonexisting_namespace_pending_delete_projects_spec.rb
  19. spec/migrations/delete_inconsistent_internal_id_records_spec.rb
  20. spec/migrations/issues_moved_to_id_foreign_key_spec.rb
  21. spec/migrations/migrate_old_artifacts_spec.rb
  22. spec/migrations/migrate_process_commit_worker_jobs_spec.rb
  23. spec/migrations/migrate_user_activities_to_users_last_activity_on_spec.rb
  24. spec/migrations/migrate_user_project_view_spec.rb
  25. spec/migrations/move_personal_snippets_files_spec.rb
  26. spec/migrations/remove_dot_git_from_usernames_spec.rb
  27. spec/migrations/remove_duplicate_mr_events_spec.rb
  28. spec/migrations/remove_orphaned_label_links_spec.rb
  29. spec/migrations/remove_project_labels_group_id_spec.rb
  30. spec/migrations/remove_soft_removed_objects_spec.rb
  31. spec/migrations/rename_more_reserved_project_names_spec.rb
  32. spec/migrations/rename_reserved_project_names_spec.rb
  33. spec/migrations/rename_users_with_renamed_namespace_spec.rb
  34. spec/migrations/schedule_create_gpg_key_subkeys_from_gpg_keys_spec.rb
  35. spec/migrations/schedule_populate_merge_request_metrics_with_events_data_spec.rb
  36. spec/migrations/turn_nested_groups_into_regular_groups_for_mysql_spec.rb
  37. spec/migrations/update_retried_for_ci_build_spec.rb
Original description

As of 2018-09-06, there are 86 offenses:

› git grep "rubocop:disable RSpec/FactoriesInMigrationSpecs" | wc -l

86

in 24 separate files:

› git grep "rubocop:disable RSpec/FactoriesInMigrationSpecs" | cut -d":" -f1 | uniq | wc -l

24

› git grep "rubocop:disable RSpec/FactoriesInMigrationSpecs" | cut -d":" -f1 | uniq

ee/spec/migrations/update_authorized_keys_file_spec.rb
spec/migrations/add_foreign_keys_to_todos_spec.rb
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb
spec/migrations/calculate_conv_dev_index_percentages_spec.rb
spec/migrations/cleanup_namespaceless_pending_delete_projects_spec.rb
spec/migrations/cleanup_nonexisting_namespace_pending_delete_projects_spec.rb
spec/migrations/delete_inconsistent_internal_id_records_spec.rb
spec/migrations/issues_moved_to_id_foreign_key_spec.rb
spec/migrations/migrate_old_artifacts_spec.rb
spec/migrations/migrate_process_commit_worker_jobs_spec.rb
spec/migrations/migrate_user_activities_to_users_last_activity_on_spec.rb
spec/migrations/migrate_user_project_view_spec.rb
spec/migrations/move_personal_snippets_files_spec.rb
spec/migrations/remove_dot_git_from_usernames_spec.rb
spec/migrations/remove_duplicate_mr_events_spec.rb
spec/migrations/remove_project_labels_group_id_spec.rb
spec/migrations/remove_soft_removed_objects_spec.rb
spec/migrations/rename_more_reserved_project_names_spec.rb
spec/migrations/rename_reserved_project_names_spec.rb
spec/migrations/rename_users_with_renamed_namespace_spec.rb
spec/migrations/schedule_create_gpg_key_subkeys_from_gpg_keys_spec.rb
spec/migrations/schedule_populate_merge_request_metrics_with_events_data_spec.rb
spec/migrations/turn_nested_groups_into_regular_groups_for_mysql_spec.rb
spec/migrations/update_retried_for_ci_build_spec.rb

and following are all the offending lines:

› git grep "rubocop:disable RSpec/FactoriesInMigrationSpecs"

ee/spec/migrations/update_authorized_keys_file_spec.rb:            2.times { @keys << create(:key) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
ee/spec/migrations/update_authorized_keys_file_spec.rb:            2.times { @keys << create(:key) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
ee/spec/migrations/update_authorized_keys_file_spec.rb:          @key_to_stay = create(:key) # rubocop:disable RSpec/FactoriesInMigrationSpecs
ee/spec/migrations/update_authorized_keys_file_spec.rb:          @key_to_delete = create(:key) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_foreign_keys_to_todos_spec.rb:  let(:project) { create(:project) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_foreign_keys_to_todos_spec.rb:  let(:user) { create(:user) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_foreign_keys_to_todos_spec.rb:    let(:note) { create(:note) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:project) { create(:project) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:pipeline_1) { create(:ci_pipeline, project: project, ref: "branch_1") } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:pipeline_2) { create(:ci_pipeline, project: other_project, ref: "branch_1") } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:pipeline_3) { create(:ci_pipeline, project: other_project, ref: "branch_1") } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:pipeline_4) { create(:ci_pipeline, project: project, ref: "branch_2") } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:mr_1) { create(:merge_request, source_project: project, target_project: project, source_branch: "branch_1", target_branch: "target_1") } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:mr_2) { create(:merge_request, source_project: other_project, target_project: project, source_branch: "branch_1", target_branch: "target_2") } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:mr_3) { create(:merge_request, source_project: project, target_project: project, source_branch: "branch_2", target_branch: "master") } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/add_head_pipeline_for_each_merge_request_spec.rb:  let!(:mr_4) { create(:merge_request, source_project: project, target_project: project, source_branch: "branch_3", target_branch: "master") } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/calculate_conv_dev_index_percentages_spec.rb:    create(:conversational_development_index_metric, # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_namespaceless_pending_delete_projects_spec.rb:      create(:project) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_namespaceless_pending_delete_projects_spec.rb:      create(:project, pending_delete: true) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_namespaceless_pending_delete_projects_spec.rb:      project = build(:project, pending_delete: true, namespace_id: nil) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_namespaceless_pending_delete_projects_spec.rb:      create(:project) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_namespaceless_pending_delete_projects_spec.rb:      create(:project, pending_delete: true) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_nonexisting_namespace_pending_delete_projects_spec.rb:    set(:some_project) { create(:project) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_nonexisting_namespace_pending_delete_projects_spec.rb:      create(:project, pending_delete: true) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_nonexisting_namespace_pending_delete_projects_spec.rb:      project = build(:project, pending_delete: true, namespace: nil, namespace_id: Namespace.maximum(:id).to_i.succ) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/cleanup_nonexisting_namespace_pending_delete_projects_spec.rb:      create(:project, pending_delete: true, namespace: create(:namespace)) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/delete_inconsistent_internal_id_records_spec.rb:# rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/issues_moved_to_id_foreign_key_spec.rb:  let!(:issue_first) { create(:issue, moved_to_id: issue_second.id) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/issues_moved_to_id_foreign_key_spec.rb:  let!(:issue_second) { create(:issue, moved_to_id: issue_third.id) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/issues_moved_to_id_foreign_key_spec.rb:  let!(:issue_third) { create(:issue) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    set(:project1) { create(:project, ci_id: 2) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    set(:project2) { create(:project, ci_id: 3) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    set(:project3) { create(:project) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    set(:pipeline1) { create(:ci_empty_pipeline, project: project1) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    set(:pipeline2) { create(:ci_empty_pipeline, project: project2) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    set(:pipeline3) { create(:ci_empty_pipeline, project: project3) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    let!(:build_with_legacy_artifacts) { create(:ci_build, pipeline: pipeline1) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    let!(:build_without_artifacts) { create(:ci_build, pipeline: pipeline1) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    let!(:build2) { create(:ci_build, pipeline: pipeline2) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_old_artifacts_spec.rb:    let!(:build3) { create(:ci_build, pipeline: pipeline3) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_process_commit_worker_jobs_spec.rb:  set(:project) { create(:project, :legacy_storage, :repository) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_process_commit_worker_jobs_spec.rb:  set(:user) { create(:user) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_user_activities_to_users_last_activity_on_spec.rb:  let!(:user_active_1) { create(:user) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_user_activities_to_users_last_activity_on_spec.rb:  let!(:user_active_2) { create(:user) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/migrate_user_project_view_spec.rb:  let!(:user) { create(:user, project_view: 'readme') } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/move_personal_snippets_files_spec.rb:      snippet = create(:personal_snippet) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/move_personal_snippets_files_spec.rb:      snippet = create(:snippet) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/move_personal_snippets_files_spec.rb:        note = create(:note_on_personal_snippet, noteable: snippet, note: "with #{markdown}") # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/move_personal_snippets_files_spec.rb:      snippet = create(:personal_snippet) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/move_personal_snippets_files_spec.rb:      snippet = create(:personal_snippet) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/move_personal_snippets_files_spec.rb:        note = create(:note_on_personal_snippet, noteable: snippet, note: "with #{markdown}") # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/move_personal_snippets_files_spec.rb:      snippet = create(:personal_snippet) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/move_personal_snippets_files_spec.rb:    create(:upload, model: snippet, path: "#{secret}/#{filename}", uploader: PersonalFileUploader) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_dot_git_from_usernames_spec.rb:  let(:user) { create(:user) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_dot_git_from_usernames_spec.rb:      let(:user2) { create(:user) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:    let(:user) { create(:user) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:    let(:merge_requests) { create_list(:merge_request, 2) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:    let(:issue) { create(:issue) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:        create(:event, :created, author: user, target: merge_requests.first), # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:        create(:event, :created, author: user, target: merge_requests.first), # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:        create(:event, :updated, author: user, target: merge_requests.first), # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:        create(:event, :created, author: user, target: merge_requests.second), # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:        create(:event, :created, author: user, target: issue), # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_duplicate_mr_events_spec.rb:        create(:event, :created, author: user, target: issue) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_project_labels_group_id_spec.rb:  let(:group) { create(:group) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_project_labels_group_id_spec.rb:  let!(:project_label) { create(:label, group_id: group.id) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_project_labels_group_id_spec.rb:  let!(:group_label) { create(:group_label) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_soft_removed_objects_spec.rb:      regular_issue = create(:issue) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_soft_removed_objects_spec.rb:      admin = create(:user, admin: true) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/remove_soft_removed_objects_spec.rb:    row = create(*args) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/rename_more_reserved_project_names_spec.rb:  let!(:project) { create(:project) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/rename_reserved_project_names_spec.rb:  let!(:project) { create(:project) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/rename_users_with_renamed_namespace_spec.rb:    other_user = create(:user, username: 'kodingu') # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/rename_users_with_renamed_namespace_spec.rb:    other_user1 = create(:user, username: 'api0') # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/rename_users_with_renamed_namespace_spec.rb:    user = create(:user, username: "Users0") # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/rename_users_with_renamed_namespace_spec.rb:    user1 = create(:user, username: "import0") # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/schedule_create_gpg_key_subkeys_from_gpg_keys_spec.rb:    create(:gpg_key, id: 1, key: GpgHelpers::User1.public_key) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/schedule_create_gpg_key_subkeys_from_gpg_keys_spec.rb:    create(:gpg_key, id: 2, key: GpgHelpers::User3.public_key) # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/schedule_populate_merge_request_metrics_with_events_data_spec.rb:  let!(:mrs) { create_list(:merge_request, 3) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/turn_nested_groups_into_regular_groups_for_mysql_spec.rb:  let!(:parent_group) { create(:group) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/turn_nested_groups_into_regular_groups_for_mysql_spec.rb:  let!(:child_group) { create(:group, parent: parent_group) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/turn_nested_groups_into_regular_groups_for_mysql_spec.rb:  let!(:project) { create(:project, :legacy_storage, :empty_repo, namespace: child_group) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/turn_nested_groups_into_regular_groups_for_mysql_spec.rb:  let!(:member) { create(:user) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/update_retried_for_ci_build_spec.rb:  let(:pipeline) { create(:ci_pipeline) } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/update_retried_for_ci_build_spec.rb:  let!(:build_old) { create(:ci_build, pipeline: pipeline, name: 'test') } # rubocop:disable RSpec/FactoriesInMigrationSpecs
spec/migrations/update_retried_for_ci_build_spec.rb:  let!(:build_new) { create(:ci_build, pipeline: pipeline, name: 'test') } # rubocop:disable RSpec/FactoriesInMigrationSpecs
Edited by Heinrich Lee Yu