Remove last remaining inline JavaScript
There are still a few places where we disable the InlineJavaScript
haml linter that was introduced in
!9742 (merged) (git grep 'InlineJavaScript'
):
-
app/views/layouts/_google_analytics.html.haml -
app/views/layouts/_init_auto_complete.html.haml -
app/views/layouts/_piwik.html.haml -
app/views/layouts/group.html.haml -
app/views/layouts/project.html.haml -
app/views/layouts/snippets.html.haml -
app/views/projects/merge_requests/show.html.haml
It also doesn't check for script
tags, this is changed by !17437 (merged) (git grep '%script'
):
-
app/views/u2f/_register.html.haml -
app/views/u2f/_authenticate.html.haml -
app/views/shared/notes/_notes_with_form.html.haml -
app/views/shared/issuable/_sidebar.html.haml -
app/views/shared/boards/_show.html.haml -
app/views/projects/tags/new.html.haml -
app/views/projects/branches/new.html.haml -
app/views/projects/edit.html.haml -
app/views/projects/graphs/charts.html.haml -
app/views/projects/issues/show.html.haml -
app/views/projects/pipelines/charts/_pipeline_times.haml -
app/views/projects/pipelines/charts/_pipelines.haml -
app/views/projects/pipelines/new.html.haml
EE-specific script
tags:
-
ee/app/views/groups/analytics/show.html.haml -
ee/app/views/profiles/slacks/edit.html.haml -
app/views/projects/blob/_header.html.haml
JS views that are eval
ed by jQuery using script
tags (find app/views -name ".js."):
-
app/views/projects/group_links/update.js.haml -
app/views/projects/remove_fork.js.haml -
app/views/projects/transfer.js.haml -
app/views/projects/tags/destroy.js.haml -
app/views/projects/refs/logs_tree.js.haml -
app/views/projects/milestones/update.js.haml -
app/views/projects/update.js.haml -
app/views/admin/labels/destroy.js.haml -
app/views/admin/runners/update.js.haml -
app/views/shared/snippets/show.js.haml -
app/views/shared/members/update.js.haml -
app/views/groups/labels/destroy.js.haml -
app/views/profiles/preferences/update.js.erb -
app/views/import/bitbucket/deploy_key.js.haml -
app/views/help/shortcuts.js.haml
There are probably also some EE-exclusive examples of inline scripting, but I haven't checked those yet.
Previous issues: #19866 (closed) #34903 (closed)
cc: @ClemMakesApps @winh