Issues page is not accessible by searching in-page for word "issue"

Summary

"Issues" page is not visible enough in Gitlab user interface.

Steps to reproduce

1. Start reporting issue of an open source project (for example, android-book-reader)
2. Realize that the project is not hosted on Github. Overcome initial confusion from the unfamiliar UI.
3. Fail to find "Issues" tab where it is usually resides in Github user interface.
4. Search for "issue" using browser's Ctrl+F feature.

What is the current bug behavior?

When I type "iss", the browser already shows no occurence.

Only after that my prior experience of using Gitlab kicks in and I remember that there is a timid non-noteworthy panel at the left where project pages are accessible.

What is the expected correct behavior?

As soon as I search, the button gets highlighted somehow.

Results of GitLab environment info

gitlab.com

Possible fixes

The buttons on panel may contain actual text, not just icons. Maybe there can be some trick with hidden, but searchable text, maybe it can be just in small font, maybe even the page can handle Cltr+F specially like Discourse.

changed the description

Why "Labels: None" even though I included /label ~bug /label ~UX at the end?

Labels can only be applied by members in this project.

marked this issue as a duplicate of #40540 (closed)

closed

reopened

@vi0oss Please could you add more detail to this issue? The link to the issues list should definitely be discoverable using the browsers find functionality when you are on the project's page

added awaiting feedback label

1. Go to https://gitlab.com/axet/android-book-reader
2. Ctrl+F
3. "issue"

FF stable: fails

Testing Firefox version 52.5.3, with multiple addons; logged in to Gitlab.

FF new

Testing Firefox version 58.0.1, clean profile.

Fullscreen window: works

Medium window: fails

Tiny window: semi-works?

At least I can see there is such thing and the link given in statusbar.

Chromium

63.0.3239.84, from Debian repo. Not logged in to Gitlab.

Fullscreen: works

Works, as the pane is visible right away.

Medium window: fails

Tiny window: semi-fails

Although it finds something, there is no further info where to look at.

I expect it to highlight the issues button somehow in medium window mode and highlight the ≡ button in tiny window mode.

@vi0oss Thanks for the feedback and noting that this issue is relevant when the left-hand nav bar is collapsed.

/cc @cperessini

added UX ~2975006 ~1749400 and removed awaiting feedback labels

added auto updated awaiting feedback labels

This is still relevant when the right-sidebar is collapsed

@sarrahvesselov Please could you take a look?

added accessibility label

removed auto updated awaiting feedback labels

Still reproducible.

"Issues" page is tricky to find (e.g. by searching in-page) unless browser window is big enough to make Gitlab show fully expanded UI.

I'm not sure what is technically possible here. Maybe making these string searchable and expanding the sidebar when the browser selects one? Or at least making sure the search highlight appears, even if you can't see the element?

@dennis do you have any suggestions?

Just show "Issues" and "Merge requests" in line with this:

Readme Files (3.5 MB) Commits (1,591) Branches (2) Tags (311) CI/CD configuration

Maybe when the panel is collapsed, maybe just always. Number of opened issues/merge requsts should be in parentheses.

Issues and merge requsts are more important compared to most other things on that panel.

"CI/CD configuration" on the other hand may be moved away to the panel, as looks more like a feature for repo admin than for contributors.

Maybe "Wiki" can also be displayed there, if it is non-empty.

@cperessini, we could possibly use something similar to what is described here https://css-tricks.com/accessible-svgs/ to address this issue. @ClemMakesApps, this may be something UX can tackle within gitlab-svgs.

@cperessini to my knowledge the text has to be visible for it to be picked up by the browser's built-in search. Even doing hacks where you can include the text but move it off-screen via text-indent would still cause confusion as it won't highlight the icon.

The options I can think off the top of my head are:

• Include the link text underneath the icon like we do for the collapsed sidebar on the right
  • 
• Include links on the overview page as suggested by @vi0oss
• Hijack browser search functionality to highlight items on the sidebar
  • Let's not do this

@cperessini, we could possibly use something similar to what is described here https://css-tricks.com/accessible-svgs/ to address this issue. @ClemMakesApps, this may be something UX can tackle within gitlab-svgs.

This would only apply to screen readers, which look at alt, desc, and aria-label attributes on elements. Browser search via CTRL + F would still not highlight these items. You can try this on the css-tricks page linked.

Hmm, I've never thought of ctrl+f to search for content including images/icons before. That seems to be different than a11y's accessibility though afaik

added [deprecated] Accepting merge requests label

added devopsmanage groupoptimize labels

removed [deprecated] Accepting merge requests label

mentioned in merge request gitlab-org/quality/triage-ops!268 (closed)

added 1 deleted label and removed devopsmanage groupoptimize labels

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue