Runners running very long builds appear offline
Summary
If a job takes very long to complete (>1h) and the runner is executing jobs sequentially, it will appear to be offline until the job finishes.
Steps to reproduce
- Make a project with a single, dedicated runner (and no shared runners)
- Set the per-job timeout to 90 minutes
- Make the build take 85 minutes
- Start a build at T hours
- The runner will go offline at T + 1h
What is the current bug behavior?
The runner appears offline.
What is the expected correct behavior?
The runner should still appear as online.
Possible fixes
- Make trace uploads count as runner activity - i.e. update runner info on trace uploads
Reported by @michaeltandy in https://gitlab.com/gitlab-org/gitlab-ce/issues/38265.
Edited by Matija Čupić