Skip to content

Membership Lock does not propagate from parent group to sub-groups

Right now whenever we create a subgroup, share_with_group_lock is inherited from the parent (https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/namespace.rb#L51). However this is not the case for membership_lock.

This can cause some confusion since it is inconsistent behaviour.

Screenshots

  • Parent group settings

Screen_Shot_2018-01-16_at_16.19.15

  • Sub-group settings

Screen_Shot_2018-01-16_at_16.20.55

This can be easily fixed by replicating what we do with share_with_group_lock in https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/namespace.rb#L51

\cc @DouweM

Edited by Chad Woolley