Clone dropdown HTTP description/tooltip could be different when signed out
Different message in ButtonHelper#http_clone_button
and ButtonHelper#ssh_clone_button
when signed out
It will currently suggest Create a personal access token on your account
or Add an SSH key to your profile
, which could be confusing. Since we're moving from a tooltip to a description this will be more obvious
Current message:
tooltip_title =
if current_user.try(:require_password_creation?)
_("Set a password on your account to pull or push via %{protocol}.") % { protocol: protocol }
else #current_user.try(:require_personal_access_token_creation_for_git_auth?)
_("Create a personal access token on your account to pull or push via %{protocol}.") % { protocol: protocol }
end
Proposal
- When the user is signed in
- For SSH option
- No change from the current implementation.
- For HTTPS option
-
The user has not set a password:
Set a password on your account to pull or push via %{protocol}.
-
The user has set a password:
Create a personal access token on your account to pull or push via %{protocol}.
-
The user has not set a password:
- For SSH option
- When the user is not signed in
- No description text needed for both SSH and HTTPS options.
Original comment
The following discussion from !15334 (merged) should be addressed:
-
@jamedjo started a discussion: (+1 comment) I know this hasn't changed, but should there be a different message when there is no user signed in? If someone was accidentally signed out it might be confusing too.
Maybe another issue
Edited by James Ramsay (ex-GitLab)