Allow cross MRs commit comments
Description
Once #31847 (closed) will be merged, we will be able to comment on a specific commit within the context of an MR. That means that the comments will persist a rebase-force-push (i.e. changing SHA)
Although this is sufficient for a single merge request lifetime, it will not correctly handle the cross MR use-case, like targeting a fork.
The goal here is to make sure the commit is a workable atom of work and that discussion can safely be used to review it.
Proposal
We should implement a mechanism that ties the comments to a context that can be shared across MRs. Ideally, this should be git-backed.
- gerrit uses a Change-Id that it appends to the commit message.
- git-notes could also be used to append review metadata
- all other clever ways to handle this
Links / references
https://git.eclipse.org/r/Documentation/user-changeid.html https://stackoverflow.com/questions/2683248/can-i-add-metadata-to-git-commits-or-can-i-hide-some-tags-in-gitk https://www.kernel.org/pub/software/scm/git/docs/git-notes.html
Feature checklist
Make sure these are completed before closing the issue, with a link to the relevant commit.
-
Feature assurance -
Documentation -
Added to features.yml