Autoscroll is not re-enabled when job log is scrolled to bottom
@bikebilly At one point (8.15 https://gitlab.com/gitlab-org/gitlab-ce/issues/19620), we had a design that explicitly said that if you manually scroll, we'll disable autoscroll, but then if you manually scroll to the bottom, we'll automatically enable autoscroll again. From what you're saying, that last part has been lost.
Basically, any time you're at the bottom, whether because of page load, scroll to bottom, or clicking the go-to-bottom button, autoscroll should be enabled.
The change may be related to these issues:
- 9.3 https://gitlab.com/gitlab-org/gitlab-ce/issues/30117
- 9.3 https://gitlab.com/gitlab-org/gitlab-ce/issues/33210
- 9.3 https://gitlab.com/gitlab-org/gitlab-ce/issues/33467
- 9.4 https://gitlab.com/gitlab-org/gitlab-ce/issues/34531
- 9.4 https://gitlab.com/gitlab-org/gitlab-ce/issues/33638
In several of those issues, the intended behavior is summarized, but somehow the summaries were missing that when you scroll to bottom, autoscroll is supposed to be re-enabled automatically.
@dimitrieh since you wrote many of them, can you comment on whether that was a conscious decision or not? I can say that from a product perspective, it was not my conscious intent.
I just tested with 10.0.3 on Chrome and confirmed the behavior is not how I intended in https://gitlab.com/gitlab-org/gitlab-ce/issues/19620. Autoscroll works until you scroll manually, then it is disabled and there's no way to reenable.
Scroll to bottom is supposed to en-enable autoscroll.
Links
Consensus/Goal
Auto scroll enables once again when the job is still running and the user touches the bottom of the log once again