Error 500 persisting when not providing a Personal Access Token for a Github project import.
Summary
When importing projects from Github, and not providing the Personal Access Token
, I get an error 500.
Furthermore, I can no longer access the https://gitlab-staging.nine.ch/import/github/new page, as I get a 500 still.
Steps to reproduce
- Go to the Github importer when creating a new project
- Do not provide a
Personal Access Token
- Click on
List your GitHub repositories
What is the current bug behavior?
I get an error 500.
What is the expected correct behavior?
- A validation error for instance on the
Personal Access Token
field. - I should still be able to return to that page to re-enter a token.
Relevant logs and/or screenshots
{"method":"GET","path":"/import/github/status","format":"html","controller":"Import::GithubController","action":"status","status":500,"error":"Projects::ImportService::Error: OAuth configuration for GitHub missing.","duration":21.16,"view":0.0,"db":0.63,"time":"2017-09-28T12:59:04.160Z","params":{},"remote_ip":"10.129.0.1","user_id":6,"username":"dadie"}
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)