500 error when opening some closed merge requests, after migration from source installation to Omnibus package and upgrade to 10.0
Summary
500 error when opening some closed merge requests, after migration from source installation to Omnibus package and upgrade to 10.0
Steps to reproduce
Open closed MR after upgrade to 10.0
Example Project
What is the current bug behavior?
it fails to open MR
What is the expected correct behavior?
the MR opens
Relevant logs and/or screenshots
Started GET "/*/ios-app/merge_requests/54" for ****** at 2017-09-23 16:41:56 +0000
Processing by Projects::MergeRequestsController#show as HTML
Parameters: {"namespace_id"=>"", "project_id"=>"ios-app", "id"=>"54"}
Completed 500 Internal Server Error in 14ms (ActiveRecord: 1.2ms)
Rugged::ReferenceError (source repository is empty):
lib/gitlab/git/repository.rb:838:in block in fetch_source_branch' lib/gitlab/git/repository.rb:806:in
with_repo_branch_commit'
lib/gitlab/git/repository.rb:834:in fetch_source_branch' app/models/repository.rb:1033:in
fetch_source_branch'
app/models/merge_request.rb:970:in write_ref' app/models/merge_request.rb:803:in
fetch_ref'
app/models/merge_request.rb:822:in ensure_ref_fetched' app/controllers/projects/merge_requests/application_controller.rb:16:in
ensure_ref_fetched'
lib/gitlab/i18n.rb:46:in with_locale' lib/gitlab/i18n.rb:52:in
with_user_locale'
app/controllers/application_controller.rb:326:in set_locale' lib/gitlab/middleware/multipart.rb:93:in
call'
lib/gitlab/request_profiler/middleware.rb:14:in call' lib/gitlab/middleware/go.rb:17:in
call'
lib/gitlab/etag_caching/middleware.rb:11:in call' lib/gitlab/request_context.rb:18:in
call'
lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'
Output of checks
sudo gitlab-rake gitlab:check SANITIZE=true
Checking GitLab Shell ...
GitLab Shell version >= 5.9.0 ? ... OK (5.9.0) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 2/5 ... ok 69/7 ... ok 71/8 ... ok 71/9 ... ok 86/10 ... ok 44/11 ... ok 71/12 ... ok 44/13 ... ok 69/14 ... ok 2/15 ... ok 1/16 ... ok 1/17 ... ok 2/18 ... ok 69/19 ... ok 4/20 ... ok 73/21 ... ok 1/22 ... ok 70/26 ... ok 69/27 ... ok 1/29 ... ok 1/31 ... ok 44/32 ... ok 73/34 ... ok 2/35 ... ok 1/37 ... ok 2/41 ... ok 58/42 ... ok 58/43 ... ok 69/44 ... ok 1/45 ... ok 2/46 ... ok 44/47 ... ok 74/48 ... ok 44/50 ... ok 69/52 ... ok 71/54 ... ok 56/55 ... ok 69/56 ... ok 69/57 ... ok 2/59 ... ok 71/61 ... ok 56/62 ... ok 69/63 ... ok 1/64 ... ok 68/66 ... ok 58/72 ... ok 1/73 ... ok 69/74 ... ok 58/75 ... ok 1/76 ... ok 43/77 ... ok 41/78 ... ok 8/79 ... ok 43/80 ... ok 69/81 ... ok 6/82 ... ok 1/83 ... ok 13/85 ... ok 36/86 ... ok 13/87 ... ok 60/88 ... ok 60/89 ... ok 60/90 ... ok 51/91 ... ok 51/92 ... ok 51/95 ... ok 44/97 ... ok 7/103 ... ok 161/104 ... ok 44/106 ... ok 65/107 ... ok 65/108 ... ok 67/110 ... ok 67/111 ... ok 4/112 ... ok 11/114 ... ok 79/115 ... ok 67/116 ... ok 74/118 ... ok 41/119 ... ok 41/120 ... ok 88/121 ... ok 65/123 ... ok 90/124 ... ok 26/125 ... ok 79/126 ... ok 79/127 ... ok 91/129 ... ok 79/130 ... ok 92/131 ... ok 26/132 ... ok 93/133 ... ok 93/134 ... ok 96/135 ... ok 97/136 ... ok 97/137 ... ok 26/139 ... ok 88/140 ... ok 11/141 ... ok 39/142 ... ok 39/143 ... ok 100/144 ... ok 100/145 ... ok 26/146 ... ok 105/147 ... ok 79/148 ... ok 105/149 ... ok 101/150 ... ok 106/151 ... ok 12/152 ... ok 79/153 ... ok 1/154 ... ok 39/156 ... ok 7/157 ... ok 79/158 ... ok 79/160 ... ok 66/161 ... ok 69/162 ... ok 26/163 ... ok 109/164 ... ok 13/165 ... ok 26/166 ... ok 26/167 ... ok 41/168 ... ok 26/169 ... ok 26/170 ... ok 69/171 ... ok 116/173 ... ok 116/174 ... ok 116/175 ... ok 41/176 ... ok 44/177 ... ok 44/178 ... ok 44/179 ... ok 117/180 ... ok 117/181 ... ok 44/182 ... ok 44/183 ... ok 7/184 ... ok 118/185 ... ok 118/186 ... ok 44/187 ... ok 120/188 ... ok 101/189 ... ok 123/190 ... ok 124/192 ... ok 125/193 ... ok 126/194 ... ok 125/195 ... ok 127/196 ... ok 126/197 ... ok 44/198 ... ok 40/199 ... ok 128/200 ... ok 128/201 ... ok 129/202 ... ok 131/203 ... ok 130/204 ... ok 105/205 ... ok 132/206 ... ok 13/208 ... ok 105/209 ... ok 135/211 ... ok 135/212 ... ok 128/214 ... ok 136/215 ... ok 136/216 ... ok 69/217 ... ok 142/218 ... ok 101/219 ... ok 101/220 ... ok 135/221 ... ok 12/222 ... ok 44/224 ... ok 143/225 ... ok 123/226 ... ok 66/227 ... ok 71/228 ... ok 12/229 ... ok 44/230 ... ok 135/232 ... ok 129/233 ... ok 129/234 ... ok 41/235 ... ok 44/236 ... ok 44/237 ... ok 44/238 ... ok 150/239 ... ok 151/240 ... ok 154/242 ... ok 4/243 ... ok 105/244 ... ok 66/245 ... ok 66/246 ... ok 154/247 ... ok 154/248 ... ok 129/249 ... ok 65/250 ... ok 100/251 ... ok 128/253 ... ok 159/254 ... ok 117/255 ... ok 160/256 ... ok 160/258 ... ok 160/259 ... ok 161/260 ... ok 162/261 ... ok 44/262 ... ok 1/263 ... ok 93/264 ... ok 162/265 ... ok 167/268 ... ok 135/269 ... ok 31/270 ... ok 44/271 ... ok 162/272 ... ok 170/274 ... ok 41/275 ... ok 105/276 ... ok 170/277 ... ok 31/278 ... ok 183/281 ... ok 183/282 ... ok 114/284 ... ok 26/285 ... repository is empty 192/286 ... ok 196/287 ... ok 198/288 ... ok 114/290 ... ok 197/291 ... ok 5/292 ... repository is empty 199/293 ... ok 199/294 ... ok 199/295 ... ok 114/297 ... ok 4/312 ... ok 196/313 ... ok 206/314 ... ok 206/315 ... repository is empty 206/316 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
2/5 ... yes
69/7 ... yes
71/8 ... yes
71/9 ... yes
86/10 ... yes
44/11 ... yes
71/12 ... yes
44/13 ... yes
69/14 ... yes
2/15 ... yes
1/16 ... yes
1/17 ... yes
2/18 ... yes
69/19 ... yes
4/20 ... yes
73/21 ... yes
1/22 ... yes
70/26 ... yes
69/27 ... yes
1/29 ... yes
1/31 ... yes
44/32 ... yes
73/34 ... yes
2/35 ... yes
1/37 ... yes
2/41 ... yes
58/42 ... yes
58/43 ... yes
69/44 ... yes
1/45 ... yes
2/46 ... yes
44/47 ... yes
74/48 ... yes
44/50 ... yes
69/52 ... yes
71/54 ... yes
56/55 ... yes
69/56 ... yes
69/57 ... yes
2/59 ... yes
71/61 ... yes
56/62 ... yes
69/63 ... yes
1/64 ... yes
68/66 ... yes
58/72 ... yes
1/73 ... yes
69/74 ... yes
58/75 ... yes
1/76 ... yes
43/77 ... yes
41/78 ... yes
8/79 ... yes
43/80 ... yes
69/81 ... yes
6/82 ... yes
1/83 ... yes
13/85 ... yes
36/86 ... yes
13/87 ... yes
60/88 ... yes
60/89 ... yes
60/90 ... yes
51/91 ... yes
51/92 ... yes
51/95 ... yes
44/97 ... yes
7/103 ... yes
161/104 ... yes
44/106 ... yes
65/107 ... yes
65/108 ... yes
67/110 ... yes
67/111 ... yes
4/112 ... yes
11/114 ... yes
79/115 ... yes
67/116 ... yes
74/118 ... yes
41/119 ... yes
41/120 ... yes
88/121 ... yes
65/123 ... yes
90/124 ... yes
26/125 ... yes
79/126 ... yes
79/127 ... yes
91/129 ... yes
79/130 ... yes
92/131 ... yes
26/132 ... yes
93/133 ... yes
93/134 ... yes
96/135 ... yes
97/136 ... yes
97/137 ... yes
26/139 ... yes
88/140 ... yes
11/141 ... yes
39/142 ... yes
39/143 ... yes
100/144 ... yes
100/145 ... yes
26/146 ... yes
105/147 ... yes
79/148 ... yes
105/149 ... yes
101/150 ... yes
106/151 ... yes
12/152 ... yes
79/153 ... yes
1/154 ... yes
39/156 ... yes
7/157 ... yes
79/158 ... yes
79/160 ... yes
66/161 ... yes
69/162 ... yes
26/163 ... yes
109/164 ... yes
13/165 ... yes
26/166 ... yes
26/167 ... yes
41/168 ... yes
26/169 ... yes
26/170 ... yes
69/171 ... yes
116/173 ... yes
116/174 ... yes
116/175 ... yes
41/176 ... yes
44/177 ... yes
44/178 ... yes
44/179 ... yes
117/180 ... yes
117/181 ... yes
44/182 ... yes
44/183 ... yes
7/184 ... yes
118/185 ... yes
118/186 ... yes
44/187 ... yes
120/188 ... yes
101/189 ... yes
123/190 ... yes
124/192 ... yes
125/193 ... yes
126/194 ... yes
125/195 ... yes
127/196 ... yes
126/197 ... yes
44/198 ... yes
40/199 ... yes
128/200 ... yes
128/201 ... yes
129/202 ... yes
131/203 ... yes
130/204 ... yes
105/205 ... yes
132/206 ... yes
13/208 ... yes
105/209 ... yes
135/211 ... yes
135/212 ... yes
128/214 ... yes
136/215 ... yes
136/216 ... yes
69/217 ... yes
142/218 ... yes
101/219 ... yes
101/220 ... yes
135/221 ... yes
12/222 ... yes
44/224 ... yes
143/225 ... yes
123/226 ... yes
66/227 ... yes
71/228 ... yes
12/229 ... yes
44/230 ... yes
135/232 ... yes
129/233 ... yes
129/234 ... yes
41/235 ... yes
44/236 ... yes
44/237 ... yes
44/238 ... yes
150/239 ... yes
151/240 ... yes
154/242 ... yes
4/243 ... yes
105/244 ... yes
66/245 ... yes
66/246 ... yes
154/247 ... yes
154/248 ... yes
129/249 ... yes
65/250 ... yes
100/251 ... yes
128/253 ... yes
159/254 ... yes
117/255 ... yes
160/256 ... yes
160/258 ... yes
160/259 ... yes
161/260 ... yes
162/261 ... yes
44/262 ... yes
1/263 ... yes
93/264 ... yes
162/265 ... yes
167/268 ... yes
135/269 ... yes
31/270 ... yes
44/271 ... yes
162/272 ... yes
170/274 ... yes
41/275 ... yes
105/276 ... yes
170/277 ... yes
31/278 ... yes
183/281 ... yes
183/282 ... yes
114/284 ... yes
26/285 ... yes
192/286 ... yes
196/287 ... yes
198/288 ... yes
114/290 ... yes
197/291 ... yes
5/292 ... yes
199/293 ... yes
199/294 ... yes
199/295 ... yes
114/297 ... yes
4/312 ... yes
196/313 ... yes
206/314 ... yes
206/315 ... yes
206/316 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.3 ? ... Exception: undefined method run_command' for SystemCheck::App::RubyVersionCheck:Class Did you mean? run_commands Git version >= 2.7.3 ? ... Exception: undefined method
run_command' for SystemCheck::App::GitVersionCheck:Class
Did you mean? run_commands
Git user has default SSH configuration? ... yes
Active users: ... 59
Checking GitLab ... Finished
Results of GitLab environment info
sudo gitlab-rake gitlab:env:info
System information System: Ubuntu 14.04 Current User: git Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.0.0 Redis Version: 3.2.5 Git Version: 2.13.5 Sidekiq Version:5.0.4 Go Version: unknown
GitLab information Version: 10.0.0 Revision: bbf5c733 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://git.*** HTTP Clone URL: https://git./some-group/some-project.git SSH Clone URL: git@git.*:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 5.9.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)