Groups API should respect subgroups

Summary

In at least one case (GET /api/v4/groups?owned=true), subgroups are not returned when they should be.

I expect GET /api/v4/groups/parent_group/projects doesn't return projects in subgroups when it should, either.

We should audit these endpoints and ensure that subgroups are supported in all cases.

Steps to reproduce

Create a hierarchy of subgroups, make API calls retrieving the results

What is the current bug behavior?

Subgroups are ignored

What is the expected correct behavior?

Subgroups should be respected

added api label

mentioned in issue #39596 (closed)

marked this issue as related to #32652 (closed)

After https://gitlab.com/gitlab-org/gitlab-ce/issues/32652 is fixed, using /groups/:id/subgroups would be a workaround for missing subgroup support in other endpoints.

mentioned in issue #28849 (closed)

added backend label

mentioned in issue #48165 (closed)

mentioned in issue #50325 (closed)

/cc @jeremy_

added Manage [DEPRECATED] and removed ~2278658 labels

marked this issue as related to #50325 (closed)

Thanks, @winh. I don't think we'll have an opportunity to prioritize this for some time (likely Q1 of 2019, as ~Manage is pretty resource constrained).

I think this could be a good one for a ~"Community Contribution", so I've marked it as such.

added [deprecated] Accepting merge requests label

I wonder if it might make sense to recursively search subgroups when specified as an optional attribute in the API request? If a group has many subgroups, do we feel it might be better for performance if we made this optional (default to false, only return projects only in the group and ignore subgroups)?

added severity3 default-severity labels

added priority3 default-priority labels

What about doing something similar as we do for members? https://docs.gitlab.com/ee/api/members.html#list-all-members-of-a-group-or-project-including-inherited-members

We could add an endpoint /api/v4/groups/all to return also inherited groups, wdyt?

Hi @jeremy ,

is there any update for the integration of this feature in the Enterprise Edition? It works in Community Edition for one of our projects, not for the second one.

Also, it's in the documentation: https://docs.gitlab.com/ee/api/groups.html#list-a-groups-projects And we can find it in the code: https://gitlab.com/search?group_id=&project_id=278964&repository_ref=&scope=blobs&search=include_subgroups

But it doesn't seem to be enabled (or I'm just dumb and I cannot make it work).

marked this issue as related to #57008 (moved)

Running into an issue where you cannot query for private subgroups directly by name if the parent is also private, even if your access token would permit access.

/api/v4/groups/<MYMAINGROUPNAME> returns MYMAINGROUPNAME's details, but

/api/v4/groups/<ASUBGROUPNAMEOFMYMAINGROUP> returns 404 not found.

/api/v4/groups/<SUBGROUPID> returns the actual group details, as expected.

added devopsmanage label

added groupauthentication and authorization [DEPRECATED] label

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue