Skip to content

`TypeError`s in Karma tests which don't fail the build

  issue_note_app
    set data
      ✔ should set notes data
08 09 2017 07:09:59.726:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
08 09 2017 07:09:59.728:WARN [web-server]: 404: /gitlab-org/gitlab-ce/noteable/issue/98/notes
      ✔ should set issue data
08 09 2017 07:09:59.747:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
08 09 2017 07:09:59.749:WARN [web-server]: 404: /gitlab-org/gitlab-ce/noteable/issue/98/notes
      ✔ should set user data
08 09 2017 07:09:59.764:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
08 09 2017 07:09:59.768:WARN [web-server]: 404: /gitlab-org/gitlab-ce/noteable/issue/98/notes
      ✔ should fetch notes
08 09 2017 07:09:59.788:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
    render
      ✔ should render list of notes
08 09 2017 07:09:59.832:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
08 09 2017 07:09:59.835:WARN [web-server]: 404: /gitlab-org/gitlab-ce/noteable/issue/98/notes
      ✔ should render form
08 09 2017 07:09:59.852:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
08 09 2017 07:09:59.856:WARN [web-server]: 404: /gitlab-org/gitlab-ce/noteable/issue/98/notes
      ✔ should render form comment button as disabled
08 09 2017 07:09:59.868:WARN [web-server]: 404: /gitlab-org/gitlab-ce/issues/26/discussions.json
08 09 2017 07:09:59.872:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
    while fetching data
      ✔ should render loading icon
08 09 2017 07:09:59.887:WARN [web-server]: 404: /gitlab-org/gitlab-ce/issues/26/discussions.json
08 09 2017 07:09:59.896:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
      ✔ should render form
08 09 2017 07:09:59.919:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
    update note
      individual note
        ✔ renders edit form
08 09 2017 07:09:59.975:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
ERROR: TypeError{}
ERROR: TypeError{}
        ✔ calls the service to update the note
08 09 2017 07:10:00.042:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
      dicussion note
        ✔ renders edit form
08 09 2017 07:10:00.099:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path
ERROR: TypeError{}
ERROR: TypeError{}
        ✔ updates the note and resets the edit form
08 09 2017 07:10:00.148:WARN [web-server]: 404: /gitlab-org/gitlab-ce/issues/26/discussions.json
08 09 2017 07:10:00.159:WARN [web-server]: 404: /environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/environments/folders/mock_path

(https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/31769741)

When fixing this, we should also make sure that errors fail the build in the future (and also that Ajax requests are mocked to make the log more readable: https://gitlab.com/gitlab-org/gitlab-ce/issues/33715).