Allow password authentication to be disabled entirely
The bulk of the changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12491 were reverted in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13956/diffs because of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12491#note_38688626 and https://gitlab.com/gitlab-org/gitlab-ce/issues/37202.
We can address the original reason https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12491 was created, by replacing the current "Sign-in enabled" option with two checkboxes.
Option 1
-
Password authentication enabled for web interface -
Password authentication enabled for Git over HTTP(S)
The current "Sign-in enabled" maps directly to the new "Password authentication enabled for web interface". "Password authentication enabled for Git over HTTP(S)" would be true for any new and existing users.
Option 2
-
Password authentication enabled -
Show sign-in form
"Password authentication enabled" being disabled implies "Show sign-in form" being disabled.
The current "Sign-in enabled" maps directly to the new "Show sign-in form". "Password authentication enabled" would be true for any new and existing users.
I prefer option 1 because it seems to more directly communicate the effect of the two options, and doesn't require the extra logic of automatically disabling "Show sign-in form" when "Password authentication enabled" is disabled.
@ryehle @dblessing What do you think?