Regression in failing pipeline email notifications
The issue
Failing pipelines always cause an email to the author of the commit, no matter the preference she set. Even when global notification is set to Disabled and "notifications about your own activity" is disabled mails are sent.
As a side note, which should have no effect, we used to have pipeline emails enabled as service template. I've disabled that one too.
Environment
Latest GitLab CE 9.5.1
Trace of issue history
#25028 (closed) was closed due to !9907 (closed) being closed in favour of !10333 (merged), which was merged. I ran into a regression according to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9907#note_38662664 a comment by @smcgivern. @godfat confirmed this.