Follow-up from "Add Multi-File Editor Using Monaco/VSCode"
The following discussions from !12198 (merged) should be addressed:
-
@mikegreiling started a discussion: (+1 comment) is this just here for phamtomjs?
-
@DouweM started a discussion: Could this incorrectly handle a file path that includes
tree
orblob
? -
@jschatz1 commented on a discussion: (+2 comments) Made this for you @DouweM https://gitlab.com/gitlab-org/gitlab-ce/issues/36042
-
@DouweM started a discussion: (+1 comment) Readme at the bottom of tree is displayed with extra border when "New repo" is disabled
-
@DouweM started a discussion: @jschatz1 Added
render_error
on the JSON. If it has any value, we should not download the raw endpoint. It may becollapsed
,too_large
or something else.Also added
data-can-commit
to the#repo
element.start_branch
will likely come tomorrow. -
@timzallmann started a discussion: Why are we changing state through jquery ?
-
@ClemMakesApps commented on a discussion: (+2 comments) We ought to add a comment on this so that it's easier to maintain/remember as we move into future iterations
-
@ClemMakesApps started a discussion: (+1 comment) Would it be easier to read if we stored
e.target.position.lineNumber
into a variable? -
@ClemMakesApps commented on a discussion: (+2 comments) We ought to document that for consistency sake, so that all our event names are no cased
-
@ClemMakesApps commented on a discussion: (+2 comments) We ought to settle on a standard for this and document it on fe_guide
-
@winh commented on a discussion: (+4 comments) can we use a wrapper (like introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7476) so that we don't have jQuery Ajax, vue resource and axios mixed in the code base?
-
@ClemMakesApps commented on a discussion: (+3 comments) We should create a follow up issue for this so it doesn't get lost
-
@mikegreiling commented on a discussion: (+4 comments) this was breaking the old-style repo view with
Uncaught ReferenceError: $ is not defined
due to the deferred script loading introduced in !12759 (merged).I've fixed this in a837664c
-
@ClemMakesApps started a discussion: We have a
IS_PRODUCTION
block below. We should utilize that instead of sprinklingIS_PRODUCTION
in the file -
@timzallmann started a discussion: I am trying it out right now and i got into a state where clicking doesn't do anything so clicking on a folder or folder up does nothing :
-
@timzallmann started a discussion: My scrollbar situation on Windows :
-
@timzallmann started a discussion: I selected a different file but nothing happened, i still see the file that i was editing before :
-
@timzallmann started a discussion: (+1 comment) I only saw it mentioned couple of times so far but not as an actual discussion, strangest thing for me is the directory structure :
-
@mikegreiling started a discussion: Noticing some odd behavior when using the back button after opening a file:
-
@mikegreiling started a discussion: The repo editor doesn't seem to know what to do with submodules and just shows an endless spinner:
The submodules also strangely show up in the repo tree view with a grey background like they are highlighted.